WordPress.org
Get WordPress

Make WordPress Core

Changes between Version 2 and Version 3 of Ticket #51014, comment 5


Ignore:
Timestamp:
08/28/2020 10:07:27 AM (3 years ago)
Author:
hansjovisyoast
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #51014, comment 5

    v2 v3  
    1 When reviewing I noticed a few code standard issues in the patch, which I addressed in `51014-2.patch`:
     1When reviewing we (a few colleagues: @justinahinon and @noudwordpress and myself) noticed a few code standard issues in the patch, which we addressed in `51014-2.patch`:
    22
    33* The `if` statement on lines 272 to 276 was not correctly indented. It had one tab too many.
    … …  
    1414-------------------------------------------------------------------------------------------------------------------
    1515}}}
    16 Since this is a pre-existing issue, where fixing it could change the behavior, I decided to leave it as is.
     16Since this is a pre-existing issue, where fixing it could change the behavior, we decided to leave it as is.