WordPress.org

Make WordPress Core

Opened 4 months ago

Closed 3 months ago

#51028 closed enhancement (fixed)

Dot should be out of the quotes.

Reported by: casiepa Owned by: SergeyBiryukov
Milestone: 5.5.1 Priority: normal
Severity: normal Version:
Component: Help/About Keywords: has-patch commit fixed-major i18n-change
Focuses: Cc:

Description

https://build.trac.wordpress.org/browser/trunk/wp-admin/about.php?marks=69#L69

The technical term is ‘lazy loading.’
=>
The technical term is ‘lazy loading’.

Attachments (1)

51028.patch (2.4 KB) - added by mukesh27 4 months ago.
Initial patch. Remove some empty spaces

Download all attachments as: .zip

Change History (17)

#1 @SergeyBiryukov
4 months ago

  • Component changed from General to Help/About
  • Milestone changed from Awaiting Review to 5.5.1

#2 follow-up: @davidbaumwald
4 months ago

Actually, I think if American-style grammar is followed, as it is in the rest of Core, the current placement is correct. See https://make.wordpress.org/core/handbook/best-practices/spelling/ for the rules favoring American style.

Reference: https://www.grammarly.com/blog/quotation-marks/

Last edited 4 months ago by davidbaumwald (previous) (diff)

#3 in reply to: ↑ 2 ; follow-up: @SergeyBiryukov
4 months ago

Replying to davidbaumwald:

Actually, I think if American-style grammar is followed, as it is in the rest of Core, the current placement is correct. See https://make.wordpress.org/core/handbook/best-practices/spelling/ for the rules favoring American style.

Just noting that the rest of core doesn't seem to be using the dot inside the quotes anywhere, and some similar instances were already fixed earlier, e.g. in [48770].

The handbook page doesn't say anything about the dot placement, though.

There was also some previous discussion in comment:49:ticket:46901.

#4 in reply to: ↑ 3 ; follow-up: @SergeyBiryukov
4 months ago

Replying to SergeyBiryukov:

There was also some previous discussion in comment:49:ticket:46901.

Per comment:50:ticket:46901, that rule appears to apply only to direct quotes (as in when quoting someone) or citations, not to normal sentences :) example:

“There was a storm last night,” Paul said.

Instead, the following is not a direct quote, nor a citation:

The technical term is ‘lazy loading’.

Version 0, edited 4 months ago by SergeyBiryukov (next)

#5 in reply to: ↑ 4 @davidbaumwald
4 months ago

Replying to SergeyBiryukov:

Replying to SergeyBiryukov:

There was also some previous discussion in comment:49:ticket:46901.

Per comment:50:ticket:46901, that rule appears to apply only to direct quotes (as in when quoting someone) or citations, not to normal sentences. For example:

“There was a storm last night,” Paul said.

Instead, the following is not a direct quote, nor a citation:

The technical term is ‘lazy loading’.

Thanks for the correction @SergeyBiryukov!

@mukesh27
4 months ago

Initial patch. Remove some empty spaces

#6 @mukesh27
4 months ago

  • Keywords has-patch added

#7 @SergeyBiryukov
4 months ago

  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#8 @SergeyBiryukov
4 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 48809:

Help/About: Fix typo and remove trailing spaces from some strings.

Props mukesh27, casiepa, davidbaumwald.
Fixes #51028.

#9 @SergeyBiryukov
4 months ago

  • Keywords commit fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for the 5.5 branch.

#10 @SergeyBiryukov
4 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 48811:

Help/About: Fix typo and remove trailing spaces from some strings.

Props mukesh27, casiepa, davidbaumwald.
Merges [48809] to the 5.5 branch.
Fixes #51028.

#11 @SergeyBiryukov
4 months ago

  • Keywords i18n-change added
  • Resolution fixed deleted
  • Status changed from closed to reopened

It occurred to me that with [48811] backported to the 5.5 branch, these strings are now left untranslated on live sites until 5.5.1 is released, which is not ideal.

It's probably not a big deal for string changes in #50887 or #50945, but the About page is far more prominent.

I don't know if there's a way to lock language packs to a particular revision for now, so I guess [48811] should be reverted and only merged back when 5.5.1 is about to be released.

Last edited 4 months ago by SergeyBiryukov (previous) (diff)

#12 @SergeyBiryukov
4 months ago

In 48813:

Help/About: Revert [48811] from the 5.5 branch for now, to avoid displaying untranslated strings on the About page.

This should be merged back when 5.5.1 is about to be released.

See #51028.

This ticket was mentioned in Slack in #polyglots by yui. View the logs.


4 months ago

This ticket was mentioned in Slack in #core by desrosj. View the logs.


3 months ago

This ticket was mentioned in Slack in #core by planningwrite. View the logs.


3 months ago

#16 @SergeyBiryukov
3 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 48932:

Help/About: Fix typo and remove trailing spaces from some strings.

Props mukesh27, casiepa, davidbaumwald.
Merges [48809] to the 5.5 branch.
Fixes #51028.

Note: See TracTickets for help on using tickets.