Opened 4 years ago
Closed 4 years ago
#51028 closed enhancement (fixed)
Dot should be out of the quotes.
Reported by: | casiepa | Owned by: | SergeyBiryukov |
---|---|---|---|
Milestone: | 5.5.1 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Help/About | Keywords: | has-patch commit fixed-major i18n-change |
Focuses: | Cc: |
Description
https://build.trac.wordpress.org/browser/trunk/wp-admin/about.php?marks=69#L69
The technical term is ‘lazy loading.’
=>
The technical term is ‘lazy loading’.
Attachments (1)
Change History (17)
#1
@
4 years ago
- Component changed from General to Help/About
- Milestone changed from Awaiting Review to 5.5.1
#3
in reply to:
↑ 2
;
follow-up:
↓ 4
@
4 years ago
Replying to davidbaumwald:
Actually, I think if American-style grammar is followed, as it is in the rest of Core, the current placement is correct. See https://make.wordpress.org/core/handbook/best-practices/spelling/ for the rules favoring American style.
Just noting that the rest of core doesn't seem to be using the dot inside the quotes anywhere, and some similar instances were already fixed earlier, e.g. in [48770].
The handbook page doesn't say anything about the dot placement, though.
There was also some previous discussion in comment:49:ticket:46901.
#4
in reply to:
↑ 3
;
follow-up:
↓ 5
@
4 years ago
Replying to SergeyBiryukov:
There was also some previous discussion in comment:49:ticket:46901.
Per comment:50:ticket:46901, that rule appears to apply only to direct quotes (as in when quoting someone) or citations, not to normal sentences. For example:
“There was a storm last night,” Paul said.
Instead, the following is not a direct quote, nor a citation:
The technical term is ‘lazy loading’.
#5
in reply to:
↑ 4
@
4 years ago
Replying to SergeyBiryukov:
Replying to SergeyBiryukov:
There was also some previous discussion in comment:49:ticket:46901.
Per comment:50:ticket:46901, that rule appears to apply only to direct quotes (as in when quoting someone) or citations, not to normal sentences. For example:
“There was a storm last night,” Paul said.
Instead, the following is not a direct quote, nor a citation:
The technical term is ‘lazy loading’.
Thanks for the correction @SergeyBiryukov!
#9
@
4 years ago
- Keywords commit fixed-major added
- Resolution fixed deleted
- Status changed from closed to reopened
Reopening for the 5.5 branch.
#11
@
4 years ago
- Keywords i18n-change added
- Resolution fixed deleted
- Status changed from closed to reopened
It occurred to me that with [48811] backported to the 5.5 branch, these strings are now left untranslated on live sites until 5.5.1 is released, which is not ideal.
It's probably not a big deal for string changes in #50887 or #50945, but the About page is far more prominent.
I don't know if there's a way to lock language packs to a particular revision for now, so I guess [48811] should be reverted and only merged back when 5.5.1 is about to be released.
Actually, I think if American-style grammar is followed, as it is in the rest of Core, the current placement is correct. See https://make.wordpress.org/core/handbook/best-practices/spelling/ for the rules favoring American style.
Reference: https://www.grammarly.com/blog/quotation-marks/