WordPress.org
Get WordPress

Make WordPress Core

Opened 4 years ago

Last modified 3 years ago

#51038 new defect (bug)

Default height when using add_theme_support( 'custom-header') in GD.

Reported by: munyagu's profile munyagu Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Media Keywords:
Focuses: Cc:

Description

add_theme_support( 'custom-header') defaults to 0 for width and height.
if you are using GD, the height will be set to 0 and the cropping will fail and you will get the error message “There has been an error cropping your image.“.
If the height is set to 0 in GD, how about getting and using the height of the source file?

Attachments (1)

51038.diff​ (695 bytes) - added by munyagu 4 years ago.

Download all attachments as: .zip

Change History (4)

#1 @munyagu
4 years ago

This problem reported by @juthadda in japanese support forum.

Last edited 4 years ago by munyagu (previous) (diff)

@munyagu
4 years ago

#2 @SergeyBiryukov
4 years ago

  • Component changed from Administration to Customize

#3 @celloexpressions
3 years ago

  • Component changed from Customize to Media

Moving to the media component as its maintainers likely have a deeper understanding of the crop function in class-wp-image-editor-gd.php, and whether 51038.diff​ is a reasonable fix.

Note: See TracTickets for help on using tickets.