Make WordPress Core

Opened 2 years ago

Last modified 5 days ago

#51041 new defect (bug)

Incorrect message about the status of WP_AUTO_UPDATE_CORE

Reported by: johnbillion's profile johnbillion Owned by:
Milestone: 6.1 Priority: normal
Severity: normal Version: 5.5
Component: Site Health Keywords: has-patch good-first-bug changes-requested
Focuses: Cc:

Description

When the following code is in place in wp-config.php, the phrasing used on the Site Health screen is confusing.

define('WP_AUTO_UPDATE_CORE', false);

The Site Health message says The WP_AUTO_UPDATE_CORE constant is defined and enabled when in fact the constant is defined and disabled.

Attachments (2)

51041.diff (586 bytes) - added by chrisbudd1 2 years ago.
Capture d’écran 2022-09-22 à 09.39.21.png (162.0 KB) - added by audrasjb 5 days ago.

Download all attachments as: .zip

Change History (16)

#1 @johnbillion
2 years ago

This message might actually be redundant due to the subsequent message in the same section that says:

WordPress security and maintenance releases are blocked by define( 'WP_AUTO_UPDATE_CORE', false );.

#2 @mukesh27
2 years ago

Hi there!

It should be disabled instead of enabled

@chrisbudd1
2 years ago

#3 @chrisbudd1
2 years ago

Created a patch to change the wording to the suggested "disabled", although it feels like "in use" might be better when paired with the later messaging:

WordPress security and maintenance releases are blocked by define( 'WP_AUTO_UPDATE_CORE', false );.

Also, neither "disabled" or "enabled" are completely accurate anyway as that message will show if you define the constant as anything unexpected (so anything that isn't true or "minor").

#4 @mukesh27
2 years ago

  • Keywords has-patch added; needs-patch removed

@chrisbudd1 Thanks for the patch and suggestions.

#5 @Clorith
4 weeks ago

  • Keywords needs-refresh good-first-bug added
  • Milestone changed from Awaiting Review to 6.1

This line should probably provide the value of the constant instead, perhaps something like this:

The %1$s constant is defined as $2$s

This would allow it the flexibility needed to account for the various values it could have that indicate it is impacting something, but not be opinionated about what it is defined as.

(the translators comment would need to be updated accordingly in a refreshed patch).

#6 @robinwpdeveloper
10 days ago

Agreed with @Clorith
Providing the value of the constant will be more useful.

#7 @Clorith
8 days ago

  • Milestone changed from 6.1 to Future Release

As the beta for WordPress 6.1 is planned for tomorrow, and the patch still needs some work, I'm moving the ticket out of the milestone. This doesn't mean it can't be worked on though, and once the patch is up to date and ready we can reevaluate its inclusion at that time :)

This ticket was mentioned in PR #3277 on WordPress/wordpress-develop by robinwpdeveloper.


7 days ago

  • Keywords needs-refresh removed

Fixes site health notice regarding WP_AUTO_UPDATE_CORE constant updated
Trac ticket: 51041

#9 @robinwpdeveloper
7 days ago

@Clorith Can you please re check and consider this one for 6.1 if everything works fine :)

#10 @prbot
7 days ago

robinwpdeveloper commented on PR #3277:

Hi @Clorith thanks for the review.
Requested changes are made and pushed.

Please let me know if there is any more issue.

This ticket was mentioned in Slack in #core by robinwpdeveloper. View the logs.


7 days ago

#12 @desrosj
7 days ago

  • Milestone changed from Future Release to 6.1

#13 @audrasjb
5 days ago

  • Keywords changes-requested added

I tested the proposed patch with define('WP_AUTO_UPDATE_CORE', false); and the second parameter returns an empty string, so it doesn't works for me. See screenshot below.

#14 @prbot
5 days ago

robinwpdeveloper commented on PR #3277:

PR updated to display constant value properly.

Note: See TracTickets for help on using tickets.