Incorrect message about the status of WP_AUTO_UPDATE_CORE

[johnbillion]

When the following code is in place in wp-config.php, the phrasing used on the Site Health screen is confusing.

define('WP_AUTO_UPDATE_CORE', false);

The Site Health message says The WP_AUTO_UPDATE_CORE constant is defined and enabled when in fact the constant is defined and disabled.

[johnbillion]

This message might actually be redundant due to the subsequent message in the same section that says:

WordPress security and maintenance releases are blocked by define( 'WP_AUTO_UPDATE_CORE', false );.

[mukesh27]

Hi there!

It should be disabled instead of enabled

[chrisbudd1]

Created a patch to change the wording to the suggested "disabled", although it feels like "in use" might be better when paired with the later messaging:

WordPress security and maintenance releases are blocked by define( 'WP_AUTO_UPDATE_CORE', false );.

Also, neither "disabled" or "enabled" are completely accurate anyway as that message will show if you define the constant as anything unexpected (so anything that isn't true or "minor").

[mukesh27]

@chrisbudd1 Thanks for the patch and suggestions.

[Clorith]

This line should probably provide the value of the constant instead, perhaps something like this:

The %1$s constant is defined as $2$s

This would allow it the flexibility needed to account for the various values it could have that indicate it is impacting something, but not be opinionated about what it is defined as.

(the translators comment would need to be updated accordingly in a refreshed patch).

[robinwpdeveloper]

Agreed with @Clorith
Providing the value of the constant will be more useful.

[Clorith]

As the beta for WordPress 6.1 is planned for tomorrow, and the patch still needs some work, I'm moving the ticket out of the milestone. This doesn't mean it can't be worked on though, and once the patch is up to date and ready we can reevaluate its inclusion at that time :)

Fixes site health notice regarding WP_AUTO_UPDATE_CORE constant updated
Trac ticket: 51041

[robinwpdeveloper]

@Clorith Can you please re check and consider this one for 6.1 if everything works fine :)

Hi @Clorith thanks for the review.
Requested changes are made and pushed.

Please let me know if there is any more issue.

[audrasjb]

I tested the proposed patch with define('WP_AUTO_UPDATE_CORE', false); and the second parameter returns an empty string, so it doesn't works for me. See screenshot below.

PR updated to display constant value properly.

[audrasjb]

using define('WP_AUTO_UPDATE_CORE', false);

[audrasjb]

using define('WP_AUTO_UPDATE_CORE', 'minor');

[audrasjb]

Alright, it looks good to me now.

[audrasjb]

In 54325:

Site Health: Fix incorrect message about the status of WP_AUTO_UPDATE_CORE.

Previously, the Site Health message said "The WP_AUTO_UPDATE_CORE constant is defined and enabled" when in fact the constant was defined and disabled using define( 'WP_AUTO_UPDATE_CORE', false );.

This changeset improves the message by providing the value of the constant. For example: "The WP_AUTO_UPDATE_CORE constant is defined as false".

Props johnbillion, chrisbudd1, robinwpdeveloper, audrasjb, Clorith.
Fixes #51041.

Committed in https://core.trac.wordpress.org/changeset/54325

[peterwilsoncc]

mukesh27 added to props via make/core per comments #2 #4.