Patch (formatting.php): notice-level error is being accidentally thrown

[richcon]

The following line in formatting.php throws a notice-leve error (Uninitialized String Offset) if '$curl' is an empty string:

29: if (isset($curl{0}) && '<' != $curl{0} && $next) { If it's not a tag

Clearly, isset($curl{0}) is intended to prevent empty strings from being tested, but isset doesn't check string offsets.

Changing to the following prevents empty strings from being considered:

if ($curl && '<' != $curl{0} && $next) { If it's not a tag

[richcon]

Patch

[darkdragon]

Well, if you are checking to see if it is not empty, then you should use !empty().

if ( !empty($curl) && '<' != $curl{0} && $next ) { // If it isn't a tag

Should be used instead.

[jacobsantos]

Duplicate of #6669