Make WordPress Core

Opened 4 years ago

Closed 3 years ago

#51053 closed defect (bug) (fixed)

Video Embeds set to aligh left disappear in Gutenberg editor

Reported by: stinkykong's profile stinkykong Owned by:
Milestone: 5.5.2 Priority: normal
Severity: normal Version: 5.5
Component: Embeds Keywords: has-patch needs-testing
Focuses: Cc:

Description

With multiple themes, I find video embed blocks (both YouTube and Vimeo) disappear from view when set to align left. If set to align center, they seem to appear. Either way, they work in the public view, just not in the editor. This is since v5.5 core update.

Change History (12)

#1 @joostdevalk
4 years ago

  • Milestone changed from Awaiting Review to 5.5.1
  • Severity changed from major to normal

Replicated this on Chaplin and after that on TwentyTwenty....

Not sure we'll be able to fix before 5.5.1 but it's a bug for sure.

#2 @stinkykong
4 years ago

Ok. Thanks for the verification.

This ticket was mentioned in Slack in #core by desrosj. View the logs.


4 years ago

#4 @desrosj
4 years ago

  • Keywords needs-patch added
  • Milestone changed from 5.5.1 to 5.5.2

Because 5.5.1 is a shorter release cycle and this does not yet have a patch, I'm going to punt. If someone is able to give this the attention it needs before 5.5.1, it can be moved back.

#5 @aristath
4 years ago

This is an issue with the embed block's editor styles so I submitted a pull-request in Gutenberg: https://github.com/WordPress/gutenberg/pull/24847
When tested & verified we can backport it in core.

This ticket was mentioned in Slack in #core by audrasjb. View the logs.


3 years ago

#7 @audrasjb
3 years ago

  • Keywords has-patch needs-testing added; needs-patch removed

Thanks for the PR. To help this to move forward, I think it would be nice to add some before/after screenshot in the PR :)

#8 @stinkykong
3 years ago

I can't really use screenshots to show something that isn't visible but I created a short video to demonstrate visually what is happening when the videos disappear in the editing window.

https://vimeo.com/468734592/5f47a4d573

#9 @whyisjake
3 years ago

Checking with @noisysocks to see if this is a viable candidate for 5.5.2.

#10 @noisysocks
3 years ago

Yep, should be OK. I'll review GB24847 and commit it to the 5.5 branch as part of #51659.

#11 @noisysocks
3 years ago

In 49372:

Editor: Update packages

@wordpress/block-directory: 1.13.7 -> 1.13.8
@wordpress/block-editor: 4.3.7 -> 4.3.8
@wordpress/block-library: 2.22.7 -> 2.22.8
@wordpress/blocks: 6.20.3 -> 6.20.4
@wordpress/components: 10.0.6 -> 10.0.7
@wordpress/core-data: 2.20.3 -> 2.20.4
@wordpress/edit-post: 3.21.7 -> 3.21.8
@wordpress/editor: 9.20.7 -> 9.20.8
@wordpress/format-library: 1.22.7 -> 1.22.8
@wordpress/icons: 2.4.0 -> 2.4.1
@wordpress/list-reusable-blocks: 1.21.6 -> 1.21.7
@wordpress/nux: 3.20.6 -> 3.20.7
@wordpress/plugins: 2.20.3 -> 2.20.4
@wordpress/server-side-render: 1.16.6 -> 1.16.7

Props talldanwp.
See #51659, #51053, #50949.

#12 @noisysocks
3 years ago

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.