WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 5 years ago

#5109 closed defect (bug) (fixed)

Patch (wp-includes/functions.php): eliminate triggered error from wp_ob_end_flush_all()

Reported by: richcon Owned by:
Milestone: 2.8 Priority: normal
Severity: normal Version: 2.7
Component: Optimization Keywords: has-patch tested
Focuses: Cc:

Description

The line from wp_ob_end_flush_all():

1416 while ( @ob_end_flush() );

triggers a notice-level error when there aren't any more buffers to flush, which is then logged when error logging is enabled. The included patch rewrites the function to avoid this.

Attachments (2)

functions.diff (372 bytes) - added by richcon 7 years ago.
Patch
functions.patch (360 bytes) - added by mrmist 5 years ago.
refreshed against 10289

Download all attachments as: .zip

Change History (6)

richcon7 years ago

Patch

comment:1 darkdragon6 years ago

  • Keywords needs-testing added

Patch should be used, but most likely would need testing.

mrmist5 years ago

refreshed against 10289

comment:2 mrmist5 years ago

  • Milestone changed from 2.9 to 2.8
  • Version changed from 2.3 to 2.7

comment:3 Denis-de-Bernardy5 years ago

  • Component changed from General to Optimization
  • Keywords tested added; needs-testing removed

comment:4 ryan5 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [11020]) Fix warning in wp_ob_end_flush_all(). Props richcon. fixes #5109

Note: See TracTickets for help on using tickets.