WordPress.org
Get WordPress

Make WordPress Core

Changes between Version 4 and Version 5 of Ticket #51092


Ignore:
Timestamp:
08/21/2020 02:38:24 PM (5 years ago)
Author:
carike
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #51092 – Description

    v4 v5  
    2121In its current form, the JSON schema does not set any fields as "required".
    2222As URLs are not one of the six data types accepted by JSON, these types have been set as "string"s. However, in the ticket to follow this one, the validation of the schema should include appropriate validation of the URLs.
     23Further tickets should include ones to update WP-CLI and WordPress.org to make the strings translatable. Thanks to Swissspidy for the comment below!
    2324
    2425{{{#!php
    2526<?php
    2627{
    27    "$schema": "https://core.trac.wordpress.org/to.be.filled.in.later",
    28    "$id": "https://example.com/to.be.filled.in.later.disclosures.tab.json",
     28   "$schema": "https://core.trac.wordpress.org/ticket/51092",
     29   "$id": "https://example.com/to.be.filled.in.later.disclosures.json",
    2930   "description": "The vision of the Disclosures Tab is for site administrators to understand their site's privacy risk profile and to make more informed privacy-related choices as a result. The mission of the Disclosures Tab is to help site administrators understand what information their site collects, where it is stored and where it is sent - and in particular, with whom it is shared.",
    3031   "type": "object",
    … …  
    3940            "slug": {
    4041               "description": "Please supply the slug, if the code relates to a plugin or a theme.",
     42               "type": "string"
     43            }
     44         }
     45      },
     46      "Licensing": {
     47         "type": "object",
     48         "properties": {
     49            "componentCode": {
     50               "description": "Please provide a URL to the license that applies to the use of this component (plugin, theme, or Core component)'s use.",
     51               "type": "string"
     52            },
     53            "localAssets": {
     54               "description": "Please provide a comma-separated list of URLs to the license that applies to the use of each asset that has been included locally. This includes the license of any bundled libraries, as well as the licenses of any images, fonts, etc.",
     55               "type": "string"
     56            },
     57            "remoteAssets": {
     58               "description": "Please provide a comma-separated list of URLs to the license that applies to the use of each asset that is accessed remotely. This includes the licenses of any external libraries, as well as the licenses of any images, fonts, etc.",
    4159               "type": "string"
    4260            }
    … …  
    5876         }
    5977      },
    60       "ThirdPartyConditions": {
     78      "ThirdPartyTerms": {
    6179         "type": "object"
    6280         "properties": {
    … …  
    7088            },
    7189            "RemoteAssets": {
    72                "description": "Please provide a comma-separated list of URLs to the license that applies to the use of each remote asset. This relates to the use of CDNs for images, fonts, etc.",
     90               "description": "Please provide a comma-separated list of URLs to the Terms of Service that applies to the use of each remote asset. This relates to the use of CDNs for images, fonts, etc.",
     91               "type": "string"
     92            },
     93            "requiresRegistration": {
     94               "description": "Please provide a comma-separated list of URLs to the Terms of Service that apply to any accounts that need to be registered in order to be able to make use of this component's code.",
    7395               "type": "string"
    7496            }
    … …  
    7799      "APIEndpoints": {
    78100         "description": "Please provide a comma-separated list of URLs for any internal API endpoints that are created by the code using example.com as the domain.",
    79          "type": "string"
    80       },
    81       "LocalAssetLicenses": {
    82          "description": "Please provide a comma-separated list of URLs to the license that applies to the use of each asset that has been included locally. This includes the license of the code, as well as the licenses of any images, fonts, etc.",
    83101         "type": "string"
    84102      },