Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#51100 closed task (blessed) (fixed)

Twenty Seventeen: Add Block Patterns

Reported by: melchoyce's profile melchoyce Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.6 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch has-copy-review commit
Focuses: Cc:


With block patterns introduced in WordPress 5.5, we now have the opportunity to add some patterns to our older default themes.

Let's consider adding some patterns to Twenty Seventeen. Perhaps some common design patterns found on business websites?

Attachments (1)

2017-patterns.png (316.4 KB) - added by melchoyce 4 years ago.

Download all attachments as: .zip

Change History (28)

#1 @melchoyce
4 years ago

Four potential pattern ideas:

  • Recent news, with heading, separator, spacer, and latest posts block.
  • A two-column pattern mimicking the two-column layout option, with heading text on the left, and a large and regular sized paragraph on the right.
  • The three columns paragraph + button pattern included in core, but with a background color adn some added separators.
  • A CTA pattern using a group block, heading, paragraph, and button.

This ticket was mentioned in Slack in #design by melchoyce. View the logs.

4 years ago

This ticket was mentioned in PR #550 on WordPress/wordpress-develop by MaggieCabrera.

4 years ago

  • Keywords has-patch added

This ticket was mentioned in Slack in #core-themes by hellofromtonya. View the logs.

4 years ago

#6 @hellofromTonya
4 years ago

  • Milestone changed from 5.6 to Future Release

In talking with @melchoyce and the core-theme team, we are punting this ticket to Future Release.

If any maintainer or committer feels this can be resolved in time, or wishes to assume ownership during a specific cycle, feel free to update the milestone accordingly.

#7 @hellofromTonya
4 years ago

  • Keywords needs-design removed
  • Milestone changed from Future Release to 5.6

Whoopsie, Mel and I got our wires crossed. Reverting to keep in milestone. Design is done. Has a patch. Sorry for the confusion.

#8 @melchoyce
4 years ago

This pattern ("Contact us") feels a little tall in-context; maybe we could adjust the min-height to 700 instead of 900?

#9 @ryelle
4 years ago

Just noting that I tested the PR & left a comment about an issue that needs fixing.

This ticket was mentioned in PR #606 on WordPress/wordpress-develop by kjellr.

4 years ago

Builds on #550.

  • Fixes pattern names.
  • Gets php docbloc in sync with other file headers.
  • Adds textdomain to translations.
  • Updates text so it uses no "lorem ipsum".
  • Fixes images.
  • Adds image license information.

Trac ticket:

#11 @kjellr
4 years ago

I built on @onemaggie's PR — fixed the bugs noted there, as well as @melchoyce's comment about the Contact Us pattern's min-height.


This ticket was mentioned in Slack in #core by hellofromtonya. View the logs.

4 years ago

#13 @kjellr
4 years ago

Also, let's please change the text strings. The ones in the latest PR came from the theme demo here — they seemed better than lorem ipsum, but they're not great.

#14 @hellofromTonya
4 years ago

  • Keywords needs-copy-review added

Noted during today's core scrub.

This ticket was mentioned in Slack in #core by hellofromtonya. View the logs.

4 years ago

#16 @helen
4 years ago

  • Type changed from enhancement to task (blessed)

I am not deeply concerned about getting this in before beta so I am marking as a task.

#17 @bridgetwillard
4 years ago

  • Keywords has-copy-review added; needs-copy-review removed

From placeholder text in GitHub

Suggested Edit

'Attract The Right Leads with Marketing Campaigns that Work'

Currently says: 'We can put together marketing campaigns and attract leads through search engine optimization.' (Line 31)

Suggested Edit

'Communicate your purpose and goals with a beautiful logo that encapsulates your business.'

Currently says: 'Our team of talented designers can create a beautiful logo and brand to encapsulate your business purpose and goals.' (Line 60)

Suggested Edit

'Need a website? We've got you covered. Our design team will create a stunning design to transform your brand.'

Currently says: 'Need a website? We’ve got you covered. Our design team will work to transform your brand into a stunning site design.' (Line 77)

Suggested Edit

'Web Design'

One of the links says 'Webdesign'. I can't find it in the code but it shows that way on the screenshot under Our Services.

Suggested Edit

'We are proud to serve outstanding clients like you.'

Currently says: 'Outstanding clients have allowed us to produce work we are proud of.' (Line 188)

Thanks for pinging me on #51098, @melchoyce.

#18 @kjellr
4 years ago

Thank you @bridgetwillard! I updated the patch on GitHub to include those copy changes. Here's how that looked:

With the new copy, two of these patterns produced single words on their own line — I'd prefer to avoid this design-wise, so I trimmed the copy there slightly:

Let me know if you have alternate suggestions for those — I'm happy to update again if need be.

#19 @bridgetwillard
4 years ago

Love it @kjellr ! That's the perfect marriage of design and copy!


This ticket was mentioned in Slack in #core-themes by hellofromtonya. View the logs.

4 years ago

kjellr commented on PR #606:

4 years ago

@carolinan, those URIs should all be escaped now. Thanks!

This ticket was mentioned in Slack in #core-themes by poena. View the logs.

4 years ago

#23 @poena
4 years ago

Tested (also on RTL), looks good to me.

There are text strings inside HTML attributes but I do not think we should start changing the escaping in the old themes.

Version 0, edited 4 years ago by poena (next)

#24 @poena
4 years ago

  • Keywords commit added

#25 @SergeyBiryukov
4 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 49584:

Bundled Themes: Introduce block patterns for Twenty Seventeen.

Props melchoyce, kjellr, onemaggie, ryelle, beafialho, bridgetwillard, poena.
Fixes #51100.

Note: See TracTickets for help on using tickets.