Make WordPress Core

Opened 4 years ago

Closed 3 years ago

#51106 closed enhancement (fixed)

Twenty Eleven: Add Block Patterns

Reported by: melchoyce's profile melchoyce Owned by: ryelle's profile ryelle
Milestone: 5.8 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch needs-copy-review
Focuses: Cc:

Description

With block patterns introduced in WordPress 5.5, we now have the opportunity to add some patterns to our older default themes.

Let's consider adding some patterns to Twenty Eleven.

Attachments (3)

51106.diff (11.0 KB) - added by melchoyce 3 years ago.
patterns.zip (183.8 KB) - added by melchoyce 3 years ago.
New image files
51106.1.diff (11.9 KB) - added by audrasjb 3 years ago.
Translation strings update

Download all attachments as: .zip

Change History (20)

This ticket was mentioned in Slack in #design by melchoyce. View the logs.


4 years ago

#2 @hellofromTonya
3 years ago

  • Milestone changed from 5.6 to Future Release

With Beta 1 for 5.6 landing in less than 2 weeks, punting this ticket to Future Release. If any maintainer or committer feels this can be resolved in time, or wishes to assume ownership during a specific cycle, feel free to update the milestone accordingly.

#3 @beafialho
3 years ago

I've worked on a few block patterns for Twenty Eleven:
https://cloudup.com/c_gLqLWullD

#4 follow-up: @kjellr
3 years ago

Thanks @beafialho!

Personally, I think these ones work the best:

https://cldup.com/TD1w2LfrjN.png

https://cldup.com/yW1iqRfPDJ-3000x3000.png

https://cldup.com/lhWJuzgf5E-3000x3000.png

https://cldup.com/YNSazOpYCX-3000x3000.png

#5 in reply to: ↑ 4 @melchoyce
3 years ago

Replying to kjellr:

Personally, I think these ones work the best ...

I agree!

Great work @beafialho.

@melchoyce
3 years ago

@melchoyce
3 years ago

New image files

#6 @melchoyce
3 years ago

Here's a patch to get us started!

#7 @melchoyce
3 years ago

  • Keywords has-patch added; needs-design removed

#8 @kjellr
3 years ago

  • Keywords needs-copy-review added

Thanks,@melchoyce! I think we'll need new copy for that "Get in Touch" one, since folks will think that's actual functionality. I'd also suggest we remove the Lorem Ipsum text and replace it with something else. Is there any existing theme demo content we can use?

Adding a "Needs Copy Review" label to get some additional eyes on that.

#9 @desrosj
3 years ago

  • Milestone changed from Future Release to 5.8

I'm going to move this to 5.8. But, if they are ready sooner we can move this to 5.7.1 (or if that's not realistic, please do move this back Future Release).

We can also release an update detached from a specific WordPress release as we did in December.

This ticket was mentioned in Slack in #core-themes by kjell. View the logs.


3 years ago

#11 @audrasjb
3 years ago

  • Keywords needs-refresh added

Hello,

I think 51106.diff needs to be updated to be translation ready.
I can take care of the patch if needed :)

@audrasjb
3 years ago

Translation strings update

#12 @audrasjb
3 years ago

  • Keywords needs-refresh removed

#13 @lukecarbis
3 years ago

The decision was made on Slack to keep this (and other theme pattern tickets) open after the feature freeze date.

https://wordpress.slack.com/archives/C01VACX5E2W/p1621972702066300

This ticket was mentioned in Slack in #core-themes by kjell. View the logs.


3 years ago

#15 @onemaggie
3 years ago

This one looks good to me!

This ticket was mentioned in Slack in #core-themes by ryelle. View the logs.


3 years ago

#17 @ryelle
3 years ago

  • Owner set to ryelle
  • Resolution set to fixed
  • Status changed from new to closed

In 51103:

Bundled Themes: Introduce block patterns for Twenty Eleven.

Props beafialho, kjellr, melchoyce, audrasjb.
Fixes #51106.

Note: See TracTickets for help on using tickets.