Twenty Ten: Add Block Patterns

[melchoyce]

With block patterns introduced in WordPress 5.5, we now have the opportunity to add some patterns to our older default themes.

Let's consider adding some patterns to Twenty Ten.

[hellofromTonya]

With Beta 1 for 5.6 landing in less than 2 weeks, punting this ticket to Future Release. If any maintainer or committer feels this can be resolved in time, or wishes to assume ownership during a specific cycle, feel free to update the milestone accordingly.

[beafialho]

I have worked on a few block patterns designs for Twenty Ten.

Take a look at them here: ​https://cloudup.com/cLRaTqaEPkb

[kjellr]

These look great! Let's update some of the text so that it's not lorem ipsum, and then I think these would be good to build.

[melchoyce]

Added some fake text to replace the lorem ipsum, updated some photos.

[melchoyce]

Forgot to add image citations

[kjellr]

@melchoyce These look good! Just a couple small notes:

The image credits include four images, but there are only three used. Should one be removed?

Also, are the spacers here just meant to make sure text lines up correctly with the image in the front-end?

If so, it seems a little weird to me, since in the Editor it looks like the text will be bottom-aligned, but it's top-aligned in the front end. I'm not sure the best way to sort that out.

I'm adding Needs Copy Review to hopefully get some additional thoughts on the copy here.

[melchoyce]

The image credits include four images, but there are only three used. Should one be removed?

Good catch! There were four patterns, then removed one because I felt it was repetitive.

Also, are the spacers here just meant to make sure text lines up correctly with the image in the front-end? If so, it seems a little weird to me, since in the Editor it looks like the text will be bottom-aligned, but it's top-aligned in the front end. I'm not sure the best way to sort that out.

Yeah, here's without:

Though actually, that would be fixed by adding margin-block-start: 0; to Twenty Ten's block styles in #52545 🤔

[kjellr]

Cool! Yeah, I think it makes sense to remove the spacers and instead fix that spacing issue in the theme. 👍

[desrosj]

I'm going to move this to 5.8. But, if they are ready sooner we can move this to 5.7.1 (or if that's not realistic, please do move this back Future Release).

We can also release an update detached from a specific WordPress release as we ​did in December.

[poena]

Hi
All the content in the patterns must be translation ready.

[danieldudzic]

Translation ready patterns

[lukecarbis]

The decision was made on Slack to keep this (and other theme pattern tickets) open after the feature freeze date.

​https://wordpress.slack.com/archives/C01VACX5E2W/p1621972702066300

[onemaggie]

I had to remove the spaces from the markup to have all block patterns show up, but heads up on the code besides that

[ryelle]

In 51106:

Bundled Themes: Introduce block patterns for Twenty Ten.

Props beafialho, kjellr, melchoyce, danieldudzic, onemaggie.
Fixes #51107.