Make WordPress Core

Opened 4 years ago

Closed 3 years ago

#51107 closed enhancement (fixed)

Twenty Ten: Add Block Patterns

Reported by: melchoyce's profile melchoyce Owned by: ryelle's profile ryelle
Milestone: 5.8 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch needs-copy-review
Focuses: Cc:

Description

With block patterns introduced in WordPress 5.5, we now have the opportunity to add some patterns to our older default themes.

Let's consider adding some patterns to Twenty Ten.

Attachments (8)

51107.diff (8.1 KB) - added by melchoyce 3 years ago.
2010-patterns.zip (209.8 KB) - added by melchoyce 3 years ago.
2010-patterns-frontend.png (1.8 MB) - added by melchoyce 3 years ago.
51107.2.diff (8.9 KB) - added by melchoyce 3 years ago.
Forgot to add image citations
51107.3.diff (8.6 KB) - added by melchoyce 3 years ago.
51107.4.diff (8.9 KB) - added by danieldudzic 3 years ago.
Translation ready patterns
51107.4.2.diff (8.7 KB) - added by onemaggie 3 years ago.
51107.5.diff (8.7 KB) - added by onemaggie 3 years ago.

Change History (24)

This ticket was mentioned in Slack in #design by melchoyce. View the logs.


4 years ago

#2 @hellofromTonya
4 years ago

  • Milestone changed from 5.6 to Future Release

With Beta 1 for 5.6 landing in less than 2 weeks, punting this ticket to Future Release. If any maintainer or committer feels this can be resolved in time, or wishes to assume ownership during a specific cycle, feel free to update the milestone accordingly.

#3 @beafialho
4 years ago

I have worked on a few block patterns designs for Twenty Ten.

Take a look at them here: https://cloudup.com/cLRaTqaEPkb

#4 @kjellr
3 years ago

These look great! Let's update some of the text so that it's not lorem ipsum, and then I think these would be good to build.

@melchoyce
3 years ago

#5 @melchoyce
3 years ago

  • Keywords has-patch added; needs-design removed

Added some fake text to replace the lorem ipsum, updated some photos.

@melchoyce
3 years ago

Forgot to add image citations

#6 @kjellr
3 years ago

  • Keywords needs-copy-review added

@melchoyce These look good! Just a couple small notes:

The image credits include four images, but there are only three used. Should one be removed?

Also, are the spacers here just meant to make sure text lines up correctly with the image in the front-end?

https://cldup.com/H3BCiVxQr2.png

If so, it seems a little weird to me, since in the Editor it looks like the text will be bottom-aligned, but it's top-aligned in the front end. I'm not sure the best way to sort that out.

I'm adding Needs Copy Review to hopefully get some additional thoughts on the copy here.

#7 @melchoyce
3 years ago

The image credits include four images, but there are only three used. Should one be removed?

Good catch! There were four patterns, then removed one because I felt it was repetitive.

Also, are the spacers here just meant to make sure text lines up correctly with the image in the front-end? If so, it seems a little weird to me, since in the Editor it looks like the text will be bottom-aligned, but it's top-aligned in the front end. I'm not sure the best way to sort that out.

Yeah, here's without:

https://cldup.com/abM3X2oAJZ.png

Though actually, that would be fixed by adding margin-block-start: 0; to Twenty Ten's block styles in #52545 🤔

@melchoyce
3 years ago

#8 @kjellr
3 years ago

Cool! Yeah, I think it makes sense to remove the spacers and instead fix that spacing issue in the theme. 👍

#9 @desrosj
3 years ago

  • Milestone changed from Future Release to 5.8

I'm going to move this to 5.8. But, if they are ready sooner we can move this to 5.7.1 (or if that's not realistic, please do move this back Future Release).

We can also release an update detached from a specific WordPress release as we did in December.

#10 @poena
3 years ago

Hi
All the content in the patterns must be translation ready.

This ticket was mentioned in Slack in #core-themes by kjell. View the logs.


3 years ago

@danieldudzic
3 years ago

Translation ready patterns

#12 @lukecarbis
3 years ago

The decision was made on Slack to keep this (and other theme pattern tickets) open after the feature freeze date.

https://wordpress.slack.com/archives/C01VACX5E2W/p1621972702066300

This ticket was mentioned in Slack in #core-themes by kjell. View the logs.


3 years ago

@onemaggie
3 years ago

#14 @onemaggie
3 years ago

I had to remove the spaces from the markup to have all block patterns show up, but heads up on the code besides that

@onemaggie
3 years ago

This ticket was mentioned in Slack in #core-themes by ryelle. View the logs.


3 years ago

#16 @ryelle
3 years ago

  • Owner set to ryelle
  • Resolution set to fixed
  • Status changed from new to closed

In 51106:

Bundled Themes: Introduce block patterns for Twenty Ten.

Props beafialho, kjellr, melchoyce, danieldudzic, onemaggie.
Fixes #51107.

Note: See TracTickets for help on using tickets.