WordPress.org
Get WordPress

Make WordPress Core

Opened 3 years ago

Closed 8 months ago

#51120 closed defect (bug) (reported-upstream)

Share Icon SVG in social-link block missing 'width' and 'height' attributes

Reported by: serjica's profile serjica Owned by:
Milestone: Priority: normal
Severity: trivial Version: 5.5
Component: Editor Keywords: has-patch
Focuses: Cc:

Description

All SVG in social-link.php have "...<svg width="24" height="24" viewBox="0 0 24 24"..." but the last one named "Share Icon" have no - "...<svg viewBox="0 0 24 24">..."
I suppose this is mistake - typing error - no WIDTH and HEIGHT and this cause very big icon.

Attachments (1)

51120.patch​ (1.1 KB) - added by tj692 13 months ago.

Download all attachments as: .zip

Change History (9)

#1 @SergeyBiryukov
3 years ago

  • Component changed from Media to Editor
  • Summary changed from Mistake in social-link svg to Share Icon SVG in social-link block missing 'width' and 'height' attributes

Hi there, welcome to WordPress Trac! Thanks for the report.

Just to clarify for anyone looking at this, the report is about the social links block added in [47250] / #49397.

@tj692
13 months ago

#2 @hansjovisyoast
13 months ago

  • Keywords has-patch added

#3 @SergeyBiryukov
13 months ago

  • Milestone changed from Awaiting Review to 6.1

Thanks for the patch!

Just noting that this should be fixed in the ​package upstream first, and then backported to core with a new version of the block library package.

Moving to the milestone for visibility.

This ticket was mentioned in ​Slack in #core by chaion07. ​View the logs.
9 months ago

#5 @chaion07
9 months ago

  • Keywords dev-feedback added

@serjica thank you for reporting this. We reviewed this ticket during a ​recent bug-scrub session. Based on the feedback received we are updating the ticket with the following changes:

  1. Add keywords dev-feedback for more visibility

Cheers!

This ticket was mentioned in ​Slack in #core by chaion07. ​View the logs.
8 months ago

#7 @chaion07
8 months ago

We reviewed this ticket during a ​recent bug-scrub session. Based on the feedback received we feel the need for the proposed changes to be made in the Gutenberg Repository first so that the work on this ticket can continue. Thanks!

Props to @robinwpdeveloper

#8 @desrosj
8 months ago

  • Keywords dev-feedback removed
  • Milestone 6.1 deleted
  • Resolution set to reported-upstream
  • Status changed from new to closed

It looks like this has been corrected upstream in the Gutenberg repository in ​f54350b. I've confirmed that this update has been merged into Core through [54257], which will be included in 6.1.

See ​Gutenberg-41373 for related discussion.

Note: See TracTickets for help on using tickets.