WordPress.org

Make WordPress Core

Opened 2 months ago

Closed 2 months ago

Last modified 2 months ago

#51127 closed defect (bug) (fixed)

Remove non-color related styling from Modern color scheme

Reported by: johnbillion Owned by: SergeyBiryukov
Milestone: 5.5.1 Priority: normal
Severity: normal Version: 5.5
Component: Administration Keywords: has-patch commit
Focuses: ui, css Cc:

Description

The Modern color scheme was introduced in #50504. In addition to its colors, it adds styling that increases the bottom padding on admin menu items.

This was pointed out in 32:ticket:50504.

No explanation for the padding was included in the change, so unless there is a good reason for it then it should be removed. Colour schemes should only affect colours otherwise we risk diverging from a consistent and predictable layout, especially if core CSS rules subsequently change.

cc @Joen - do you have any information about this increased admin menu padding?

Change History (13)

#1 @Joen
2 months ago

Hi!

I believe that my have been an error on my part. It looks like a remainder of a failed separate exploration. Thanks for the ticket, should be safe to remove. Would you like a PR?

#2 @johnbillion
2 months ago

  • Keywords needs-patch added; 2nd-opinion removed
  • Milestone changed from Awaiting Review to 5.6

Great, thanks for the info Joen. Yes please!

This ticket was mentioned in PR #497 on WordPress/wordpress-develop by jasmussen.


2 months ago

  • Keywords has-patch added; needs-patch removed

This PR fixes a padding value present in the modern scheme, which shouldn't be there.

Fixes https://core.trac.wordpress.org/ticket/51127

Before:

<img width="200" alt="Screenshot 2020-08-25 at 09 39 22" src="https://user-images.githubusercontent.com/1204802/91146756-9ca9d180-e6b7-11ea-9975-06f8eb71f210.png">

After:

<img width="179" alt="Screenshot 2020-08-25 at 09 42 52" src="https://user-images.githubusercontent.com/1204802/91146763-9f0c2b80-e6b7-11ea-92bd-950879f5a479.png">

This ticket was mentioned in PR #497 on WordPress/wordpress-develop by jasmussen.


2 months ago

  • Keywords has-patch added; needs-patch removed

This PR fixes a padding value present in the modern scheme, which shouldn't be there.

Fixes https://core.trac.wordpress.org/ticket/51127

Before:

<img width="200" alt="Screenshot 2020-08-25 at 09 39 22" src="https://user-images.githubusercontent.com/1204802/91146756-9ca9d180-e6b7-11ea-9975-06f8eb71f210.png">

After:

<img width="179" alt="Screenshot 2020-08-25 at 09 42 52" src="https://user-images.githubusercontent.com/1204802/91146763-9f0c2b80-e6b7-11ea-92bd-950879f5a479.png">

#4 @Joen
2 months ago

  • Keywords needs-patch added; has-patch removed

#5 @Joen
2 months ago

  • Keywords has-patch added; needs-patch removed

I messed up the keywords!

#6 @SergeyBiryukov
2 months ago

  • Keywords commit added

#7 @johnbillion
2 months ago

  • Milestone changed from 5.6 to 5.5.1

Looks good. I see no reason for this not to go into 5.5.1. Any objections?

#8 @Joen
2 months ago

No objections!

#9 @prbot
2 months ago

jasmussen commented on PR #497:

I'm unable to merge this branch, but please do let me know if you need my help with anything specific here!

#10 @SergeyBiryukov
2 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 48862:

Administration: Remove non-color related styling from Modern color scheme.

Color schemes should only affect colors, to avoid diverging from a consistent and predictable layout, especially if core CSS rules subsequently change.

Follow-up to [48277], [48286], [48345].

Props Joen, johnbillion, afercia, johnjamesjacoby.
Fixes #51127. See #50504.

#11 @SergeyBiryukov
2 months ago

In 48863:

Administration: Remove non-color related styling from Modern color scheme.

Color schemes should only affect colors, to avoid diverging from a consistent and predictable layout, especially if core CSS rules subsequently change.

Follow-up to [48277], [48286], [48345].

Props Joen, johnbillion, afercia, johnjamesjacoby.
Merges [48862] to the 5.5 branch.
Fixes #51127. See #50504.

Note: See TracTickets for help on using tickets.