Avoid the Enable/Disable auto-updates links to appear for externally hosted themes on the Network Admin > Themes screen

[audrasjb]

This is a follow-up to #50280

As noted by @pbiron in comment number 66:

---

The above (Note: see [48688]) commit did not include the requisite changes to WP_MS_Themes_List_Table. The impact is that in multisite, the Enable/Disable auto-updates links will still appear for externally hosted themes on the Network Admin > Themes screen.

I'm looking into what it will take to add the multisite support for this. It's complicated by the fact that plugins use an array (returned by get_plugin_data()) and thus can use array_merge() on the info in the transient, array( 'update-supported => true ) and the plugin_data; whereas themes use an instance of WP_Theme...making the array merge not possible.

I think something can be worked out using the magic __get() and __set() methods of WP_Theme...but still looking into that.

[afragen]

So I have a patch that seems to correctly set the auto-update tabs count in prepare_items() and correctly adds/removes the Enable|Disable auto-updates links in column_autoupdates().

Themes are very much different from plugins as we know.

I'm missing why we actually need the theme headers for setting the auto-updates. Can someone explain this a bit for me? I've been working with plugin/theme updates for a while and know I can add the array( 'update-supported => true ) if it's really needed.

[afragen]

I don't know how I messed up your description edit @SergeyBiryukov, but I think I fixed it.

[afragen]

Initial pass at a patch. This should correctly do the following.

1. Count the number of enabled/disabled auto-updates in the network themes tabs.
2. Correctly display or not display the auto-update link.
3. Add the auto_update_theme filter to multisite.

I'm certain this isn't complete, but it's a start.

[pbiron]

Thanx for the patch @afragen

51129.2.diff​ builds on it and I think brings the multisite themes list table into parity with the plugins list table, as far as how the "Automatic Updates" column is populated.

A few things to note:

1. it does not relying on the __get() and __set() magic methods of WP_theme (as suggested in my comment on the other ticket). It simply dynamically creates the update_supported and auto_update_forced properties of the WP_Theme objects as needed.
2. notice that those property names are slightly different than the dynamic array keys used in the plugins list table (which are update-supported and auto-update-forced). That makes it easier to get/set those dynamic properties. We could use $theme->{'update-supported'}, but that syntax of really hard to deal with :-)
3. it correctly (I think) displays Auto-update enabled or Auto-update disabled as plain text (instead of the normal enable/disable links) when the auto_update_theme filter returns a non-null value (51129.diff​ didn't do that)

With 5.5.1-RC1 scheduled for tomorrow, this could use some testing ASAP.

[afragen]

fix loose comparison

[afragen]

Fixes a loose comparison that exists in class-wp-plugins-list-table.php line 1127 that was copied. Discussed with @pbiron.

@SergeyBiryukov you might want to fix that  🙃

[audrasjb]

Before last patch

[audrasjb]

After last patch

[audrasjb]

Just tested the last patch on a multisite with a custom theme and it works fine.
I also reviewed the code and it looks good on my side.

[afragen]

@audrasjb and the theme that doesn’t have an auto-updates link should show in the Disabled auto-updates tab.

[audrasjb]

The theme without auto-update available shows in the disable tab

[audrasjb]

@afragen yes, I can confirm

[SergeyBiryukov]

In 48899:

Upgrade/Install: Only display the auto-update links on the Network Admin > Themes screen for themes that support the feature.

Follow-up to [48669], [48688].

Props afragen, pbiron, audrasjb, desrosj, SergeyBiryukov.
Fixes #51129.

[SergeyBiryukov]

In 48900:

Upgrade/Install: Only display the auto-update links on the Network Admin > Themes screen for themes that support the feature.

Follow-up to [48669], [48688].

Props afragen, pbiron, audrasjb, desrosj, SergeyBiryukov.
Merges [48899] to the 5.5 branch.
Fixes #51129.