WordPress.org

Make WordPress Core

Opened 10 months ago

Closed 4 months ago

Last modified 2 months ago

#51132 closed enhancement (maybelater)

Embeds: Add support for Deezer

Reported by: justinahinon Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Embeds Keywords: has-patch
Focuses: Cc:

Description

Major music editor like Deezer doesn't have an embed block.
It would be good to have one for it.

Attachments (1)

51132.patch (1.2 KB) - added by ayeshrajans 10 months ago.

Download all attachments as: .zip

Change History (9)

@ayeshrajans
10 months ago

#1 @justinahinon
10 months ago

  • Keywords needs-testing added

#2 @desrosj
7 months ago

  • Keywords reporter-feedback added
  • Version trunk deleted

There is a set of questions regarding whitelisting oEmbed providers which that we ask are answered prior to considering a new embed service. Do you mind answering them @justinahinon? https://make.wordpress.org/core/handbook/contribute/design-decisions/#whitelisting-oembed-providers

#3 follow-up: @justinahinon
7 months ago

Whitelisting Deezer oEmbed provider:

Is the service is popular enough for core developers to have heard of it before? Is it “mainstream?”

Deezer is a quite popular service; with "14 million monthly active users, and 7 million paid subscribers as of January 2019".

Source: https://en.wikipedia.org/wiki/Deezer

If similar services are already supported, how does this service compare in terms of size, features, and backing?

I guess what is being asked here is if WordPress already supports other services like Deezer?

Spotify, Soundcloud, and Youtube which are quite similar already have embeds in the block editor.

Does this service have a large following on Twitter, Facebook, or other social media? Is its Twitter account verified?

Yes, their Twitter, Facebook, Instagram and Youtube accounts are all certified and have a large follower base.

Is its oEmbed endpoint clearly established and properly documented? (Sometimes, they are just a developer’s pet project that may not be supported.)

Their seems to have a documented oEmbed endpoint here and here.

Does the oEmbed endpoint work with WordPress’ oEmbed auto-discovery? If not, could it be made to work with additional HTML tags or attributes being whitelisted?

When you add a link to a Deezer track in the editor, it is not recognized.

But I think it's because the structure of the endpoint URL for Deezer is slightly different from other services? https://www.deezer.com/plugins/player

It shoudl be possible to adapt this structure.

Does the service make an effort to build relationships with developers, such as through robust APIs?

Yes, there is an API documentation as well as a regular engineering blog.

How old is the service?

The service is 13 years old.

Source: https://en.wikipedia.org/wiki/Deezer

Does it have a well-established Wikipedia article? (Seriously.)

Yes: https://en.wikipedia.org/wiki/Deezer

Has anyone written a WordPress plugin that leverages the service in some way, whether adding it as an oEmbed provider, creating a shortcode, or leveraging other APIs of the service? Do these plugins have any noticeable adoption or traction that would indicate usage and demand?

The only plugin I've found is this https://wordpress.org/plugins/deezer-widget.
And it has not receive an update for 8 years now.

Is the provider frequently proposed?

The current ticket is the only one I'm seeing in Trac and Gutenberg repo for this provider.

Last edited 7 months ago by justinahinon (previous) (diff)

#4 in reply to: ↑ 3 @desrosj
7 months ago

  • Keywords needs-testing reporter-feedback removed
  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Replying to justinahinon:

Is its oEmbed endpoint clearly established and properly documented? (Sometimes, they are just a developer’s pet project that may not be supported.)

Their seems to have a documented oEmbed endpoint here and here.

Does the oEmbed endpoint work with WordPress’ oEmbed auto-discovery? If not, could it be made to work with additional HTML tags or attributes being whitelisted?

When you add a link to a Deezer track in the editor, it is not recognized.

But I think it's because the structure of the endpoint URL for Deezer is slightly different from other services? https://www.deezer.com/plugins/player

It shoudl be possible to adapt this structure.

Hmm, it does not seem like that documentation is for an oEmbed service, but rather some type of widget embed code generator. In order to be added as a whitelisted oEmbed provider in Core, the oEmbed format needs to be supported.

I'm going to close this out as it does not appear that Deezer currently supports oEmbeds. But if new information presents itself, feel free to reopen!

#5 @desrosj
7 months ago

  • Keywords has-patch added
  • Milestone set to Future Release
  • Resolution wontfix deleted
  • Status changed from closed to reopened

My apologies! I managed to locate documentation right after I closed the ticket. The second link @justinahinon provided above documents the oEmbed service for Deezer (it requires you to log in first, and I had not refreshed).

https://developers.deezer.com/api/oembed-endpoint looks to document a valid oEmbed service.

I think that it should be alright to whitelist this service. Going to leave this for a bit to receive feedback from others before adding.

Last edited 7 months ago by desrosj (previous) (diff)

#6 @dd32
5 months ago

IMHO:

✅ Does the oEmbed endpoint work with WordPress’ oEmbed auto-discovery? If not, could it be made to work with additional HTML tags or attributes being whitelisted?

Deezer does not support oEmbed auto-discovery. Given 51132.patch's simplicity it appears that if they simply added support for auto-dscovery it would work.

✅ Does the service make an effort to build relationships with developers, such as through robust APIs?

The API documentation being hidden behind a login portal, which includes the below restriction tends to suggest to me that the answer to the above question is not a tick to me.

https://developers.deezer.com/termsofuse

IV. NON-COMMERCIAL USE
The Developer agrees that the use of the Services is strictly limited for a non-commercial purpose and in a non-commercial environment.

(That is not a guideline which WordPress can guarantee)

#7 @desrosj
4 months ago

  • Milestone Future Release deleted
  • Resolution set to maybelater
  • Status changed from reopened to closed

I'm going to close this one out as a maybelater. If their services turn on oEmbed auto-discovery, and their terms of use are updated, we can reconsider.

#8 @Hareesh Pillai
2 months ago

#53030 was marked as a duplicate.

Note: See TracTickets for help on using tickets.