WordPress.org

Make WordPress Core

Opened 4 weeks ago

Last modified 3 days ago

#51157 new defect (bug)

Bundled Themes: List block appears too far to the left after 5.5 upgrade

Reported by: kjellr Owned by:
Milestone: 5.5.2 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-screenshots has-patch needs-testing
Focuses: css, rtl Cc:

Description (last modified by SergeyBiryukov)

After upgrading to WordPress v5.5, the list block appears too far to the left in the editor in some themes:

  • Twenty Fourteen
  • Twenty Sixteen
  • Twenty Seventeen

(Possibly a couple more, but we should test and verify)

This was fixed in Twenty Fifteen earlier this year, so these themes likely need a similar fix: #50029

More details in this GitHub issue:
https://github.com/WordPress/gutenberg/issues/24780


http://cldup.com/LkCxBQaH8Q.jpg

http://cldup.com/cG4MIyW3wJ.png

Attachments (6)

51157.patch (2.7 KB) - added by amolv 6 days ago.
Default List margin removed from theme.
Capture d’écran 2020-09-19 à 10.28.58.png (157.4 KB) - added by audrasjb 4 days ago.
After the patch (Twenty Eleven example)
Twenty-Fifteen-RTL-first-patch.png (151.5 KB) - added by sabernhardt 4 days ago.
Editor with various lists in Twenty Fifteen, in Arabic
Twenty-Eleven-RTL-first-patch.png (102.4 KB) - added by sabernhardt 4 days ago.
Editor with various lists in Twenty Eleven, in Arabic
51157.1.patch (7.0 KB) - added by amolv 3 days ago.
Patch refresh, RTL language support.
RTL language support.png (643.4 KB) - added by amolv 3 days ago.
Test after patch refresh.

Download all attachments as: .zip

Change History (13)

#1 @SergeyBiryukov
4 weeks ago

  • Description modified (diff)
  • Milestone changed from Awaiting Review to 5.5.2

#2 @sabernhardt
3 weeks ago

  • Focuses css added

@amolv
6 days ago

Default List margin removed from theme.

#3 @amolv
6 days ago

  • Keywords has-patch added; needs-patch removed

twentyten, twentyeleven, twentythirteen, twentyfourteen, twentysixteen, twentyseventeen - in this themes, default margin of list is removed like #50029

Last edited 6 days ago by amolv (previous) (diff)

@audrasjb
4 days ago

After the patch (Twenty Eleven example)

#4 @audrasjb
4 days ago

  • Keywords has-screenshots added; needs-testing removed

I tested the proposed patch and it fixes the issue for each related bundled theme.
Marking this for commit.

#5 @audrasjb
4 days ago

  • Keywords commit added

#6 @sabernhardt
4 days ago

  • Focuses rtl added
  • Keywords needs-patch added; has-patch commit removed

The patch looks good with regular list blocks in LTR languages, but it still needs some adjustments for RTL support (even Twenty Fifteen).

@sabernhardt
4 days ago

Editor with various lists in Twenty Fifteen, in Arabic

@sabernhardt
4 days ago

Editor with various lists in Twenty Eleven, in Arabic

@amolv
3 days ago

Patch refresh, RTL language support.

@amolv
3 days ago

Test after patch refresh.

#7 @amolv
3 days ago

  • Keywords has-patch needs-testing added; needs-patch removed

CSS updated for RTL language support.

Note: See TracTickets for help on using tickets.