l10n.php missing validation

[vickdini]

Hi! I was updating an automation script and, while debugging, I noticed that the line 1075 of the file \wp-includes\l10n.php performs a comparison operation between two array elements before verifying the existence of both (i.e. one is verified, the other isn't and this one throws an error):

Current line 1075:

} elseif ( ! isset( $src_url['host'] ) || $src_url['host'] === **$site_url['host']** ) {

Proposed change:

} elseif ( ! isset( $src_url['host'] ) **|| ! isset( $site_url['host'] )** || $src_url['host'] === $site_url['host'] ) {

I hope this helps.

Best regards,

Vick

[vickdini]

Hi! I was updating an automation script and, while debugging, I noticed that the line 1075 of the file \wp-includes\l10n.php performs a comparison operation between two array elements before verifying the existence of both (i.e. one is verified, the other isn't and this one throws an error):

Current line 1075:

} elseif ( ! isset( $src_url['host'] ) || $src_url['host'] === $site_url['host'] ) {

Proposed change:

} elseif ( ! isset( $src_url['host'] ) || ! isset( $site_url['host'] ) || $src_url['host'] === $site_url['host'] ) {

I hope this helps.

Best regards,

Vick

[SergeyBiryukov]

Hi there, welcome to WordPress Trac!

Thanks for the report, we're already tracking this issue in #49145.