Opened 4 years ago
Closed 4 years ago
#51175 closed defect (bug) (fixed)
Wrong reply box title
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 5.5.2 | Priority: | normal |
Severity: | normal | Version: | 5.5 |
Component: | Comments | Keywords: | has-patch commit fixed-major |
Focuses: | docs | Cc: |
Description
Probably introduced in #38009.
Steps: Click to reply in a new tab. Then click on any other reply link. Observe the duplicate text of the name.
Attachments (4)
Change History (18)
#1
@
4 years ago
- Component changed from General to Comments
- Milestone changed from Awaiting Review to 5.5.2
@
4 years ago
comment form title()
function $link_to_parent
parameter default value going false after it's working fine.
#4
@
4 years ago
- Keywords needs-refresh added
The patch looks good at a glance.
I think we'll just want to update the Doc Block comment as well.
@
4 years ago
Comments: Return false
to $link_to_parent
parameter by default in comment_form_title()
to avoid double title edge cases
#6
@
4 years ago
- Focuses docs added
- Keywords commit added; dev-feedback removed
Thanks @audrasjb for doc updates.
Added commit keyword
#7
@
4 years ago
- Keywords needs-refresh added; commit removed
I'm pretty hesitant to change the default value of a function without exploring it's usage in the wild (especially since this function has been around since 2.7.0). I think a better solution would be to call comment_form_title()
with the optional third parameter to override the default when the reply to query arguments are present.
Another way to fix this could be to always include the "default" title in the output markup and update the JS to look for that (though that may have backwards compatibility concerns for themes).
Looking into this further, it doesn't appear that #38009 is causing this (though it if is, any changes here should be backported to the 5.5 branch. It seems like this line is responsible.
This ticket was mentioned in Slack in #core by audrasjb. View the logs.
4 years ago
#9
@
4 years ago
- Milestone changed from 5.5.2 to Future Release
Thanks @desrosj. Indeed, those are valid concerns. Let's move this ticket to Future release
.
#10
@
4 years ago
- Keywords commit added; needs-refresh removed
- Milestone changed from Future Release to 5.5.2
After some testing, it looks like this is indeed a bug in the implementation of [47506] / #38009.
When clicking the "Reply" link, the text content of the heading is updated to include the comment author's name, but that doesn't account for the link to the initial parent comment, which remains there as well.
51175.2.diff hides the extra link when clicking "Reply", and shows it again when clicking "Cancel reply".
Hi there!
Same issue replicated Twenty Twenty theme.