Theme_Installer_skin::do_overwrite does not work on a Windows server

[bobbingwide]

In my local Windows development environment I tried the new logic to upload plugin and theme .zip files. It worked for plugins but not for themes.

I traced through the code and determined that $current_theme_data was never being set because this loop assumes the character separator is always '/'.

foreach ( $all_themes as $theme ) {
   if ( rtrim( $theme->get_stylesheet_directory(), '/' ) !== $folder ) {
	continue;
   }
   $current_theme_data = $theme;
} 

In my windows environment
$theme->get_stylesheet_directory() returns, for example

C:\apache\htdocs\cwiccer/wp-content/themes/twentyfifteen

whereas the value of $folder was

C:/apache/htdocs/cwiccer/wp-content/themes/twentyfifteen

Since $current_theme_data is not set the option to replace the theme is not displayed.

[bobbingwide]

This change resolves the problem.

foreach ( $all_themes as $theme ) {
    $stylesheet_dir = $theme->get_stylesheet_directory();
    $stylesheet_dir = str_replace( '\\', '/', $stylesheet_dir);
    if ( rtrim( $stylesheet_dir, '/' ) !== $folder ) {
	continue;
   }
   $current_theme_data = $theme;
}

[bobbingwide]

patch to support Windows

[SergeyBiryukov]

Thanks for the patch! Just noting this should probably use wp_normalize_path() instead.

[mukesh27]

Thanks for the patch @wpamitkumar

Patch working fine for me.

[bobbingwide]

Yup, 51182-2.diff is neater.

[SergeyBiryukov]

In 48913:

Themes: Normalize the installed theme path in Theme_Installer_Skin::do_overwrite() before comparing with the uploaded theme.

This ensures that the data for the currently installed theme is picked up properly when uploading a theme update on Windows.

Follow-up to [48390].

Props bobbingwide, wpamitkumar, mukesh27.
Fixes #51182.

[SergeyBiryukov]

Reopening for backporting to the 5.5 branch after a second committer's review.

[desrosj]

Looks good for backporting.

[desrosj]

In 48919:

Themes: Normalize the installed theme path in Theme_Installer_Skin::do_overwrite() before comparing with the uploaded theme.

This ensures that the data for the currently installed theme is picked up properly when uploading a theme update on Windows.

Follow-up to [48390].

Props bobbingwide, wpamitkumar, mukesh27.
Merges [48913] to the 5.5 branch.
Fixes #51182.