Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#51212 closed defect (bug) (fixed)

Gutenberg Block Search should use plugin short description

Reported by: dd32's profile dd32 Owned by: desrosj's profile desrosj
Milestone: 5.6 Priority: normal
Severity: normal Version:
Component: Editor Keywords: has-patch has-unit-tests commit
Focuses: Cc:


Currently the Block Searching displays blocks with a truncated description field, while the API provides a short_description output specifically for that.

The attached PR simply switches it to using the shorter description field which is more relevant for the limited display space of blocks.

Since this has been merged to core, and the change is in PHP I think this is supposed to be submitted here rather than directly to the Gutenberg repo which also contains this class?

Change History (11)

This ticket was mentioned in PR #510 on WordPress/wordpress-develop by dd32.

4 years ago

  • Keywords has-patch added

Use the short description field for block searches

Trac ticket:

#2 @TimothyBlynJacobs
4 years ago

Yeah AFAIK the workflow is to make the change here, then it could be backported to Gutenberg since they have a polyfill of the endpoint for 5.4 users.

#3 @desrosj
4 years ago

  • Milestone changed from Awaiting Review to 5.6

Moving this to 5.6.

ryelle commented on PR #510:

4 years ago

It looks like the test test_prepare_item in tests/phpunit/tests/rest-api/rest-block-directory-controller.php needs to be updated, since the expected description should be the short_description now. Otherwise this is working great in manual testing.

#5 @ryelle
4 years ago

I approved the PR but I don't think that's showing up here. Patch is working, and the updated tests are passing 👍🏻

#6 @hellofromTonya
4 years ago

  • Keywords has-unit-tests added

PR 610 includes update in unit test.

This ticket was mentioned in Slack in #core by hellofromtonya. View the logs.

4 years ago

#8 @johnbillion
4 years ago

  • Keywords commit added

#9 @desrosj
4 years ago

  • Owner set to desrosj
  • Status changed from new to reviewing

#10 @helen
4 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 49559:

Editor: Display short description from block directory in results.

Props dd32, ryelle.
Fixes #51212.

Note: See TracTickets for help on using tickets.