WordPress.org

Make WordPress Core

Opened 6 months ago

Closed 11 days ago

Last modified 11 days ago

#51224 closed defect (bug) (fixed)

Twenty Thirteen: Cover block alignment issues

Reported by: melchoyce Owned by: ryelle
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

The cover block positioning is broken in Twenty Thirteen. Centered content is offset, and trying to use the new block alignment tool positions content off-screen.

Attaching screenshots to demonstrate.

Attachments (2)

2013-cover-bottomleft.png (99.6 KB) - added by melchoyce 6 months ago.
Using the "bottom left" alignment option in the cover block
2013-cover-centered.png (110.1 KB) - added by melchoyce 6 months ago.
Default, center alignment

Download all attachments as: .zip

Change History (8)

@melchoyce
6 months ago

Using the "bottom left" alignment option in the cover block

@melchoyce
6 months ago

Default, center alignment

This ticket was mentioned in PR #992 on WordPress/wordpress-develop by kjellr.


2 weeks ago

  • Keywords has-patch added

Trac ticket: https://core.trac.wordpress.org/ticket/51224

---

This PR clears up the front-end display of cover block children. To match the editor, they have their margins set to auto, and are always the default width.*

_*I find this part weird, but that's how these appear in the editor, so I figured let's match that._

Test content: https://gist.github.com/kjellr/cb83095e95b28cc914e970ca0c7f7b18

## Screenshots

_Before:_
https://i0.wp.com/user-images.githubusercontent.com/1202812/107678706-ba6cf200-6c69-11eb-85cc-ae3945ef159b.png

_After:_
https://i0.wp.com/user-images.githubusercontent.com/1202812/107678734-c062d300-6c69-11eb-9126-d14c25b9286c.png

_Editor (for reference):_
https://i0.wp.com/user-images.githubusercontent.com/1202812/107678756-c789e100-6c69-11eb-9c01-9cf585f85fd1.png

#2 @prbot
2 weeks ago

melchoyce commented on PR #992:

Seeing some weirdness in the placeholder still:

https://i0.wp.com/user-images.githubusercontent.com/2846578/107689975-7c76ca80-6c77-11eb-81ec-cecf421a5145.png

Everything else seems to be working 👍

#3 @prbot
2 weeks ago

kjellr commented on PR #992:

That's the Group block placeholder, right? I hadn't touched that block in this PR, so I think that's a separate bug. I took a quick look now, but the fix isn't obvious, so I suggest we punt that to a separate bug report + PR.

#4 @prbot
2 weeks ago

melchoyce commented on PR #992:

Sounds good 👍

#5 @ryelle
11 days ago

  • Owner set to ryelle
  • Resolution set to fixed
  • Status changed from new to closed

In 50346:

Twenty Thirteen: Fix alignment of child blocks within the Cover block.

Props kjellr, melchoyce.
Fixes #51224.

#6 @prbot
11 days ago

ryelle commented on PR #992:

Committed in r50346.

Note: See TracTickets for help on using tickets.