WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 2 of Ticket #51248


Ignore:
Timestamp:
09/04/2020 10:00:58 PM (6 years ago)
Author:
SergeyBiryukov
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #51248

    • Property Owner set to SergeyBiryukov
    • Property Status changed from new to accepted

  • Ticket #51248 – Description

    initial v2  
    33[48521] introduced a method for displaying a comment type drop-down for filtering on the Comments list table.
    44
    5 For some reason, the method is called `::comment_status_dropdown()`, despite not having to anything with a comment status. This can be confusing when working on tickets like #20977 in the future.
     5For some reason, the method is called `::comment_status_dropdown()`, despite not having to do anything with a comment status. This can be confusing now and problematic when working on tickets like #20977 in the future.
    66
    77I propose renaming the method to `::comment_type_dropdown()` for clarity. It's marked as protected, so there should not be any backward compatibility concerns.