Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#5127 closed task (blessed) (fixed)

Move all mysql_* function calls to wp-db.php

Reported by: ComputerGuru Owned by: westi
Milestone: 2.5 Priority: normal
Severity: normal Version: 2.3
Component: General Keywords: mysql has-patch
Focuses: Cc:


All calls to database-specific functions should be in a single file for portablility and organization purposes (in this case, wp-db.php for MySQL).

The only mysql_* function not yet constrained to wp-db.php is mysql_get_server_info();

Patch attached. Changes schema.php, upgrade.php, and wp-db.php.

Attachments (1)

mysql_ grouping.patch (1.6 KB) - added by ComputerGuru 8 years ago.

Download all attachments as: .zip

Change History (5)

#1 @Nazgul
8 years ago

  • Keywords has-patch added
  • Milestone changed from 2.3.1 to 2.4
  • Version set to 2.3

As this is a "feature request", I'm bumping the milestone to 2.4.
Feature requests shouldn't be done in maintenance releases.

#2 @westi
8 years ago

  • Owner changed from anonymous to westi
  • Status changed from new to assigned

Adding to my review and checkin todo list

#3 @ryan
8 years ago

The entire function should be moved into wpdb:check_server_version() with it returning an error message via WP_Error.

#4 @westi
8 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [6199]) Move all calls to mysql_ functions to withiWPDB so that t we don't expect any mysql stuff when we are using a custo$wpdb class. Fixes #5127
props ComputerGuru.

Note: See TracTickets for help on using tickets.