Return result of set_theme_mod

[latifi]

Return result of set_theme_mod to handle errors

https://core.trac.wordpress.org/ticket/51296

[Hareesh Pillai]

Patch refreshed

[Hareesh Pillai]

Hi @latifi, welcome to Trac. Thanks for the ticket and PR.

I have refreshed the patch in 51296.diff. Also updated @return in the doc block.
Should we also update the remove_theme_mod function?

[SergeyBiryukov]

In 49214:

Themes: Add a return value to set_theme_mod() to allow for error handling.

Props latifi, hareesh-pillai.
Fixes #51296.

[SergeyBiryukov]

Replying to Hareesh Pillai:

I have refreshed the patch in 51296.diff. Also updated @return in the doc block.

Thanks for the refresh!

Should we also update the remove_theme_mod function?

Just noting that this seemed like a good idea, but turned out a bit more complicated, as there are a couple of scenarios where it returns null:

• If the theme mod was not set.
• If it was the last remaining theme mod for the theme.

So adding a return value to remove_theme_mod() could be explored in a new ticket if someone feels strongly about it :)

Merged in changeset https://core.trac.wordpress.org/changeset/49214