Changes between Initial Version and Version 1 of Ticket #51299, comment 5
- Timestamp:
- 09/24/2020 12:47:39 AM (5 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #51299, comment 5
initial v1 3 3 Thanks for the patch! Some thoughts: 4 4 5 * From a technical point of view, if the `$title` variable is not used anywhere else in the class and is not passed to any filters, I don't think it makes sense to keep it. I see it being passed to the `nav_menu_item_title` filter, but the result is no longer used anywhere after this patch.5 * From a technical point of view, if the `$title` variable is not used anywhere else in the class and is not passed to any filters, I don't think it makes sense to keep it. I see it being passed to the `nav_menu_item_title` filter, but the result of that is no longer used anywhere after this patch. 6 6 * I think this will have big front-end implications for a lot of websites. For example, https://wordpress.org/ has these title attributes on some menu items. With this change, would they be gone? 7 7 * Documentation: "Documentation, tutorials, best practices."