WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 5 years ago

#5132 closed defect (bug) (worksforme)

installer redirect broken in IIS with php running as CGI

Reported by: Denis-de-Bernardy Owned by:
Milestone: Priority: normal
Severity: normal Version: 2.3
Component: Administration Keywords:
Focuses: Cc:

Description

it looks for ./css/install.css

might it be ./admin/css/install.css instead?

D.

Change History (10)

comment:1 Denis-de-Bernardy7 years ago

I'm tracing this to:

function wp_admin_css_uri( $file = 'wp-admin' ) {
	if ( defined('WP_INSTALLING') )
	{
		$_file = add_query_arg( 'version', get_bloginfo( 'version' ), "./$file.css" );
	} else {
		$_file = add_query_arg( 'version', get_bloginfo( 'version' ), get_option( 'siteurl' ) . "/wp-admin/$file.css" );
	}
	return apply_filters( 'wp_admin_css_uri', $_file, $file );
}

should be more like:

function wp_admin_css_uri( $file = 'wp-admin' ) {
	if ( defined('WP_INSTALLING') )
	{
		$_file = add_query_arg( 'version', get_bloginfo( 'version' ), "./" . ( strpos('wp-admin', $_SERVER['REQUEST_URI']) === false ? 'wp-admin/' : '' ) . "$file.css" );
	} else {
		$_file = add_query_arg( 'version', get_bloginfo( 'version' ), get_option( 'siteurl' ) . "/wp-admin/$file.css" );
	}
	return apply_filters( 'wp_admin_css_uri', $_file, $file );
}

comment:2 Denis-de-Bernardy7 years ago

better yet:

<?php wp_admin_css( 'css/install' ); ?>

should be more like:

<?php wp_admin_css( 'wp-admin/css/install' ); ?>

in wp-admin/install.css

(or conditionally based on whether wp-admin is in there or not)

D.

comment:3 Denis-de-Bernardy7 years ago

along the same lines, the log is missing too

comment:4 Denis-de-Bernardy7 years ago

(I'm really tired, it was of course meant in the wp-admin/install.php file, not the wp-admin/install.css file)

comment:5 Denis-de-Bernardy7 years ago

lastly, the url in the form submit seems wrong. so it may simply turn out that a redirect is missing. in any event, the installer seems very broken, or at least it is on my windows box...

comment:6 Denis-de-Bernardy7 years ago

  • Priority changed from high to normal
  • Severity changed from trivial to normal
  • Summary changed from stylesheet is missing in install screen? to installer redirect broken in IIS with php running as CGI

investigating this still further, the underlying issue seems to be the redirect to the installer when loading this in IIS running php as CGI. I've tried in *nix and it worked quite fine over there.

It is a niggle for development servers. One can work around it by "manually" visiting wp-admin/install.php obviously, but it would be sweet if it worked out of the box...

comment:7 Denis-de-Bernardy7 years ago

and while we're at it, when you get redirected from wp-admin/install.php to wp-config.php on the same platform, you get an error whereby wp-config.php is not around, even though it is... reloading works, but it's kind of weird.

comment:8 westi6 years ago

  • Milestone changed from 2.3.1 to 2.3.2

2.3.1 has been released moving to 2.3.2

comment:9 lloydbudd6 years ago

  • Milestone changed from 2.3.2 to 2.5

comment:10 Denis-de-Bernardy5 years ago

  • Milestone 2.9 deleted
  • Resolution set to worksforme
  • Status changed from new to closed

works now

Note: See TracTickets for help on using tickets.