PHP Notice while moving post to trash (post_type has 2 registered taxonomies both with default_term set)

[szaqal21]

While moving post to trash a PHP Notice is thrown:

PHP Notice:  Undefined index: logaction in /var/www/html/czt.dev.puw.rz/wp-includes/post.php on line 4053

post_type has 2 registered taxonomies both with default_term set.

Taxonomy "logaction" is registered as second, first is "logontype" and for this taxonomy no notice is thrown.

I think that this condition:

<?php
if ( isset( $postarr['tax_input'] ) && is_array( $postarr['tax_input'][ $taxonomy ] ) ) {
        $postarr['tax_input'][ $taxonomy ] = array_filter( $postarr['tax_input'][ $taxonomy ] );
}

should be changed to:

<?php
if ( isset( $postarr['tax_input'][ $taxonomy ] ) && is_array( $postarr['tax_input'][ $taxonomy ] ) ) {
        $postarr['tax_input'][ $taxonomy ] = array_filter( $postarr['tax_input'][ $taxonomy ] );
}

This notice wasn't thrown when I had only 1 taxonomy registered, it showed after registering second taxonomy.

On first loop iteration

<?php
isset( $postarr['tax_input'] )

is FLASE, but for second iteration it is TRUE that's why

<?php
is_array( $postarr['tax_input'][ $taxonomy ] )

is throwing a notice because $taxonomy key isn't set in $postarr array.

[SergeyBiryukov]

Hi there, thanks for the ticket!

Introduced in [48480].

Corrected the check of the existence of an array key.

Trac ticket: https://core.trac.wordpress.org/ticket/51320

[audrasjb]

Hi,
Tested on my side: adding an isset check to test the sub-array fixes the issue. It looks good to go.
Marking this for commit and removing the related keyword.

[Hareesh Pillai]

Refreshed patch

[SergeyBiryukov]

In 49328:

Posts, Post Types: Check if taxonomy is set for the tax_input parameter of wp_insert_post().

This avoids a PHP notice when creating a post with multiple taxonomies both having a default term.

Props yakimun, szaqal21, hareesh-pillai, audrasjb.
Fixes #51320.

[SergeyBiryukov]

Reopening for backporting to the 5.5 branch.

[SergeyBiryukov]

In 49332:

Posts, Post Types: Check if taxonomy is set for the tax_input parameter of wp_insert_post().

This avoids a PHP notice when creating a post with multiple taxonomies both having a default term.

Props yakimun, szaqal21, hareesh-pillai, audrasjb.
Merges [49328] to the 5.5 branch.
Fixes #51320.

Trac ticket was closed with changeset https://core.trac.wordpress.org/changeset/49332.