WordPress.org

Make WordPress Core

Opened 10 months ago

Closed 10 months ago

Last modified 10 months ago

#51329 closed enhancement (wontfix)

The (Create New Page) button on the options-privacy.php settings page should go to the new-post.php screen, not the edit post.php screen.

Reported by: zenithcity Owned by:
Milestone: Priority: normal
Severity: normal Version: 4.9.6
Component: Privacy Keywords:
Focuses: administration Cc:

Description

The (Create New Page) button on the options-privacy.php settings page does not actually do what it says, instead of redirecting to the post-new.php admin screen, it still redirects to the edit post.php admin screen, and this is misleading because there is an edit link on the same options-privacy.php settings page which redirects to the edit post.php admin screen.

Change History (7)

#1 follow-up: @carike
10 months ago

  • Component changed from Administration to Privacy
  • Focuses administration added

Just moving this to the Privacy component for workflow purposes.

#2 in reply to: ↑ 1 @zenithcity
10 months ago

Replying to carike:

Great! I was unsure whether using the privacy component for this would be ideal.

#3 @garrett-eclipse
10 months ago

  • Keywords close added; needs-patch removed

Hello @zenithcity thank you for the feedback, unfortunately I don't see this change as feasible so am going to mark for closure but leave for a 2nd opinion before closing out as wontfix.

A few reasons the existing workflow is how it is and why it probably won't change;

  1. The new Privacy Policy page gets pre-populated with content from the Privacy Policy Guide. Pre-population requires the page already exists (is created).
  2. The new page gets set as the sites current Privacy Policy page. For a page to be selected as the Privacy Policy page it must first exist (be created).

It is these additional process steps which lead us to the edit page instead of the create as they require the page existing.

If you prefer to manually create your pages you definitely can, you would just need to handle populating the page as well as assigning it as the Privacy Policy page in the Privacy settings.

Hopefully that makes sense, I really don't see a way to redirect to the create screen instead of the edit screen without disabling the two above mentioned processes. And there isn't much additional benefit of going that way either since you can edit the title and everything else from the edit screen anyway.

#4 @garrett-eclipse
10 months ago

  • Keywords 2nd-opinion added

#5 follow-up: @zenithcity
10 months ago

Hello @garrett-eclipse, I understand, that makes sense. But wouldn't it be nice if the Create New Page is eventually removed. Right now, having it together with the edit page link on the privacy policy settings page looks like a duplicate. Also, renaming it to (Edit New Page) would be meaningful because that is what the button does.

#6 in reply to: ↑ 5 @garrett-eclipse
10 months ago

  • Keywords close 2nd-opinion removed
  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed
  • Version changed from 5.5.1 to 4.9.6

Replying to zenithcity:

Hello @garrett-eclipse, I understand, that makes sense. But wouldn't it be nice if the Create New Page is eventually removed. Right now, having it together with the edit page link on the privacy policy settings page looks like a duplicate. Also, renaming it to (Edit New Page) would be meaningful because that is what the button does.

I'll agree that the proximity and the fact they're both primary buttons beside the same label. This has caused some confusion (ex. related recent Slack comment). This is being improved upon in #49264 with the redesign effort for the Privacy Settings screen.

That being said I am against removal of the action as it streamlines a multi-step process into a single Privacy Policy page creation step. As can be found from an initial mockup of the redesign the action will be preserved, however segregated more appropriately;
https://core.trac.wordpress.org/raw-attachment/ticket/49264/49264.5_preview.gif

As well I wouldn't trade 'Create' for 'Edit' on the action verbiage as it is still a creation process irregardless of the resulting view presented to the user. Other create actions for posts/pages/users require a 'new-item' form view as they require user input before the item can be created, with the create Privacy Policy page process the only action required is the single click as all information required for page creation exist as defaults (Title = Privacy Policy, Content = <Privacy Policy Guide Content>) so there's no need for the interstitial 'add-new' screen. The result of creating a privacy policy is the same as a page it's just skipping the middle steps to save the admin time.

As there's already a ticket to address the proximity conflict I'm going to close this. Also with that other ticket the Settings API should be introduced meaning a simple filter should be able to exclude any undesired actions or modify them.

#7 @zenithcity
10 months ago

Okay, I see where this is going, I get it now, just that the (Create New Page) button was ambiguous at first, thanks.

Note: See TracTickets for help on using tickets.