WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #51330, comment 11


Ignore:
Timestamp:
10/03/2020 03:21:10 PM (5 years ago)
Author:
anonymized_8769252
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #51330, comment 11

    initial v1  
    1 Thanks for working on this, because `_should_load_block_editor_scripts_and_styles` is an improvement over having to check `WP_Screen:: is_block_editor`. Especially because `is_block_editor()` is poorly designed, see [this comment](https://core.trac.wordpress.org/ticket/45037#comment:21).
     1Thanks for working on this, because `_should_load_block_editor_scripts_and_styles` is an improvement over having to check `WP_Screen:: is_block_editor`. Especially because `is_block_editor()` is poorly designed, see https://core.trac.wordpress.org/ticket/45037#comment:21.
    22
    33But `is_block_editor` is a public method, and therefore a public API. The newly introduced function on the other hand is private--and there's no reason for that. It's only a getter function with a filter, and should therefore follow the established WordPress pattern of being public.