WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#51335 closed defect (bug) (fixed)

Twenty Twenty: Update URL of php.net date format table

Reported by: mukesh27 Owned by: SergeyBiryukov
Priority: normal Milestone: 5.6
Component: I18N Version:
Severity: minor Keywords: good-first-bug has-patch
Cc: Focuses:

Description

Added new ticket for bundle theme. Check #51332 for more information.

There are a lot of /* translators: ... */ comments pointing people to ​https://www.php.net/date to reference the tokens that can be used in date( $format, ... ).

Attachments (1)

51335.diff​ (615 bytes ) - added by Hareesh Pillai 6 years ago.

Download all attachments as: .zip

Change History (5)

@Hareesh Pillai
6 years ago

#1 @Hareesh Pillai
6 years ago

  • Keywords has-patch added; needs-patch removed
  • Severity normal → minor

#2 @mukesh27
6 years ago

Thanks for the patch @hareesh-pillai, looks good to me.

Please note: we use good-first-bug keyword to identify easy bugfixes so new contributors can learn how to make a patch and contribute to WP Core. It's a very helpful way to onboard new contributors, so please remember to give them priority on those :)

#3 @SergeyBiryukov
6 years ago

  • Milestone Awaiting Review → 5.6
  • Owner set to SergeyBiryukov
  • Status new → reviewing

#4 @SergeyBiryukov
6 years ago

  • Resolution → fixed
  • Status reviewing → closed

In 48992:

Twenty Twenty: Update the URL for PHP date formats table in translator comments.

Follow-up to [48991].

Props hareesh-pillai, mukesh27, iandunn.
Fixes #51335. See #51332.

Note: See TracTickets for help on using tickets.