WordPress.org

Make WordPress Core

Opened 13 months ago

Last modified 4 days ago

#51337 new defect (bug)

Twenty Twenty: Custom Logo bug in the Customizer

Reported by: acosmin Owned by:
Milestone: 5.9 Priority: normal
Severity: normal Version: 5.5
Component: Bundled Theme Keywords: has-patch needs-testing has-testing-info
Focuses: Cc:

Description

This ticket is based on a bug discovered by @ilovewpcom

 I think I found a weird bug in the theme. It's not breaking anything, just some odd behaviour.

 Steps to replicate the issue:
 1. Start with a website that doesn't have a logo in the Site Identity.
 2. Open the Customize page and open the Site Identity panel.
 3. Upload a logo and DON'T click the Publish button.
 4. Change the site title or description under the logo.

 Right after step 4 you will notice that the logo disappears in the previewer and the site title becomes a lot bigger.
 If you click the Publish button to save the changes then everything is correct on the front-end.
 The only issue is with the previewer's odd behaviour.
 I hope this helps :)

A solution for this is to add:

'container_inclusive' => version_compare( $GLOBALS['wp_version'], '5.5', '>=' ),

on class-twentytwenty-customize.php:L50

It probably needs more testing.

Attachments (1)

51337.patch (818 bytes) - added by sabernhardt 7 weeks ago.

Download all attachments as: .zip

Change History (3)

@sabernhardt
7 weeks ago

#1 @sabernhardt
7 weeks ago

  • Keywords has-patch needs-testing added
  • Milestone changed from Awaiting Review to 5.9

Thanks for the report!

I reproduced the error in Twenty Twenty with several earlier WordPress versions, going back to the minimum version (4.7):

5.8
5.4.6
5.3.8
5.0.13
4.9.18
4.8.17 (with WP_DEBUG set to false)
4.7.21 (WP_DEBUG false again)

So this probably does not need to check the version, and container_inclusive seems to fix it.

Note: I did not experience the same problem with other bundled themes, from Twenty Fifteen to Twenty Twenty-One (using WP 5.8).

#2 @Boniu91
4 days ago

  • Keywords has-testing-info added
Note: See TracTickets for help on using tickets.