WordPress.org
Get WordPress

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#51355 closed defect (bug) (fixed)

Have the Copy URL button and Copied text conform to the Site Health and Privacy Guide

Reported by: garrett-eclipse's profile garrett-eclipse Owned by: garrett-eclipse's profile garrett-eclipse
Milestone: 5.6 Priority: normal
Severity: normal Version:
Component: Media Keywords: has-patch has-screenshots commit
Focuses: ui, accessibility, css, administration Cc:

Description

The ClipboardJS implementation applied to the Copy URL button (#48463) can conform a little better with the two other implementations (Site Health and Privacy Guide) in core by doing two things;

  1. Make the 'Copied!' text green.
  2. Make the button verbiage clear that it's copied 'to clipboard'

Attachments (6)

e4af56481b8eb66dd8de12f984b74ceb.gif​ (27.7 KB) - added by garrett-eclipse 4 years ago.
Copy URL before.
36970c1d494d9644b400dce8a45c764e.gif​ (20.7 KB) - added by garrett-eclipse 4 years ago.
Privacy Copy
2e9b1e6c34ff1bff1c495a77b3b19b1f.gif​ (13.7 KB) - added by garrett-eclipse 4 years ago.
Site Health copy
51355.diff​ (3.4 KB) - added by garrett-eclipse 4 years ago.
Initial patch to make the Copied text green and the button verbiage append 'to clipboard'
33dce8485e6341e72c38f522f82b0027 (1).gif​ (22.1 KB) - added by garrett-eclipse 4 years ago.
AFTER Copy URL on attachment details screen
15805a1bce9f74072d395d838fde4577.gif​ (37.2 KB) - added by garrett-eclipse 4 years ago.
AFTER Copy URL on attachment popup modal

Download all attachments as: .zip

Change History (10)

@garrett-eclipse
4 years ago

Copy URL before.

@garrett-eclipse
4 years ago

Privacy Copy

@garrett-eclipse
4 years ago

Site Health copy

@garrett-eclipse
4 years ago

Initial patch to make the Copied text green and the button verbiage append 'to clipboard'

@garrett-eclipse
4 years ago

AFTER Copy URL on attachment details screen

@garrett-eclipse
4 years ago

AFTER Copy URL on attachment popup modal

#1 @mukesh27
4 years ago

51355.diff​ patch working fine for me.

#2 @garrett-eclipse
4 years ago

  • Keywords commit added; needs-testing removed
  • Milestone changed from Awaiting Review to 5.6
  • Owner set to garrett-eclipse
  • Status changed from new to accepted

Thanks for testing @mukesh27 let's see if we can get this into 5.6.

This ticket was mentioned in ​Slack in #core-css by kirstyburgoine. ​View the logs.
4 years ago

#4 @SergeyBiryukov
4 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 49064:

Media: Make the "Copy URL" button implementation more consistent with other instances in core:

  • Make the "Copied!" text green.
  • Make the button verbiage clear that it's copied "to clipboard".

Props garrett-eclipse, mukesh27.
Fixes #51355.

Note: See TracTickets for help on using tickets.