WordPress.org

Make WordPress Core

#51371 closed defect (bug) (fixed)

Use sentence case for Privacy Bulk Action response notices.

Reported by: garrett-eclipse Owned by: garrett-eclipse
Milestone: 5.6 Priority: normal
Severity: normal Version: 4.9.6
Component: Privacy Keywords: has-patch has-screenshots commit
Focuses: ui, administration, ui-copy Cc:

Description

The Bulk Actions for privacy request tables produce notices upon response. These should be sentence case to follow along with other core strings.

Specifically these strings are;
_n( 'Deleted %d request', 'Deleted %d requests', $count )
_n( 'Re-sent %d request', 'Re-sent %d requests', $count )

Attachments (2)

51371.diff (923 bytes) - added by garrett-eclipse 10 months ago.
Make privacy request bulk action response notices sentence case.
Screen Shot 2020-09-21 at 4.10.28 PM.png (27.6 KB) - added by garrett-eclipse 10 months ago.
Current no period

Download all attachments as: .zip

Change History (5)

@garrett-eclipse
10 months ago

Make privacy request bulk action response notices sentence case.

#1 @mukesh27
10 months ago

  • Keywords needs-testing removed

51371.diff patch looks fine for me in WordPress 5.6-alpha-48958 version

#2 @garrett-eclipse
10 months ago

  • Keywords commit added
  • Status changed from assigned to accepted

Thanks @mukesh27 let's move this to commit

#3 @desrosj
10 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 49035:

Privacy: Ensure bulk action related strings end with periods.

Props garrett-eclipse, mukesh27.
Fixes #51371.

Note: See TracTickets for help on using tickets.