Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#51385 closed defect (bug) (fixed)

Add missing @return tags for WP_Automatic_Updater methods

Reported by: ankitmaru's profile ankitmaru Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.6 Priority: normal
Severity: normal Version:
Component: Upgrade/Install Keywords: has-patch
Focuses: coding-standards Cc:


Missing @return tag in function/method PHPDoc comment

Attachments (3)

class-wp-automatic-updater.php.patch (653 bytes) - added by ankitmaru 4 years ago.
class-wp-automatic-updater.php.2.patch (895 bytes) - added by ankitmaru 4 years ago.
class-wp-automatic-updater.php.3.patch (1.1 KB) - added by ankitmaru 4 years ago.

Download all attachments as: .zip

Change History (9)

#1 @mukesh27
4 years ago

  • Component changed from General to Upgrade/Install
  • Keywords needs-refresh added
  • Version trunk deleted

Hi there!

Thanks for the patch. Can you please add send_core_update_notification_email() function return type and other function which miss the return type?

#2 @ankitmaru
4 years ago

@mukesh27 I have updated the file added the missing return statements.


#3 @mukesh27
4 years ago

  • Keywords needs-refresh removed

Thanks for the patch

#4 @SergeyBiryukov
4 years ago

  • Milestone changed from Awaiting Review to 5.6
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#5 @SergeyBiryukov
4 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 49061:

Docs: Add missing @return tags for some WP_Automatic_Updater methods:

  • ::is_vcs_checkout()
  • ::should_update()
  • ::send_core_update_notification_email()

Props ankitmaru, mukesh27.
Fixes #51385.

#6 @SergeyBiryukov
4 years ago

  • Summary changed from Coding Standards / Doc Comments fixes to Add missing @return tags for WP_Automatic_Updater methods
Note: See TracTickets for help on using tickets.