#51387 closed defect (bug) (fixed)
Add trash post type label
Reported by: | ntsekouras | Owned by: | SergeyBiryukov |
---|---|---|---|
Milestone: | 6.3 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Posts, Post Types | Keywords: | has-patch needs-testing has-dev-note |
Focuses: | administration | Cc: |
Description
Now as we can see from the available post type labels, there is not one for trashing an entity.
Ref here: https://developer.wordpress.org/reference/functions/get_post_type_labels/.
In Gutenberg when you trash an entity should show a message from the labels, so as to be translated as well.
Related issue in Gutenberg here: https://github.com/WordPress/gutenberg/issues/19144
Change History (10)
This ticket was mentioned in PR #4253 on WordPress/wordpress-develop by @James Roberts.
19 months ago
#3
- Keywords has-patch added; needs-patch removed
@James Roberts commented on PR #4253:
19 months ago
#5
E2E test locally gives the following results:
Test Suites: 6 passed, 6 total Tests: 15 passed, 15 total Snapshots: 0 total Time: 117.714 s, estimated 224 s
Would it be possible to re-run it?
#7
@
16 months ago
- Owner set to SergeyBiryukov
- Resolution set to fixed
- Status changed from new to closed
In 55923:
@SergeyBiryukov commented on PR #4253:
16 months ago
#8
Thanks for the PR! Merged in r55923.
#10
@
15 months ago
- Keywords has-dev-note added; needs-dev-note removed
Added to misc dev note.
draft: https://make.wordpress.org/core/?p=106236&preview=1&_ppp=2977223417
Added the
item_trashed
default label to theget_default_labels()
method.This update adds the
item_trashed
default label to theget_default_labels()
method. As per #25604 , this should allow #25563 to move forward now that the strings are translatable. Note: #25563 was reverted, pending this update to core.Testing Instructions:
noticeMessage = ${ postType.labels.singular_name } trashed.;
, usenoticeMessage = postType.labels.item_trashed;
npm run build
.Trac ticket: https://core.trac.wordpress.org/ticket/51387