Make WordPress Core

Opened 3 years ago

Last modified 2 months ago

#51387 new defect (bug)

Add trash post type label

Reported by: ntsekouras's profile ntsekouras Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Posts, Post Types Keywords: has-patch needs-testing
Focuses: administration Cc:


Now as we can see from the available post type labels, there is not one for trashing an entity.
Ref here:

In Gutenberg when you trash an entity should show a message from the labels, so as to be translated as well.

Related issue in Gutenberg here:

Change History (5)

#1 @SergeyBiryukov
3 years ago

  • Component changed from General to Posts, Post Types

#2 @johnbillion
3 years ago

  • Keywords needs-patch added

This ticket was mentioned in PR #4253 on WordPress/wordpress-develop by @James Roberts.

2 months ago

  • Keywords has-patch added; needs-patch removed

Added the item_trashed default label to the get_default_labels() method.

This update adds the item_trashed default label to the get_default_labels() method. As per #25604 , this should allow #25563 to move forward now that the strings are translatable. Note: #25563 was reverted, pending this update to core.

Testing Instructions:

  1. Manually apply the changes in #25563 to a local copy of the Gutenberg plugin.
  2. Remove the if statement [ here].
  3. Instead of noticeMessage = ${ postType.labels.singular_name } trashed.;, use noticeMessage = postType.labels.item_trashed;
  4. Re-build Gutenberg - npm run build.
  5. Open a post in the editor - On the Document settings pane, click on "Move to trash".
  6. Voice Over should read "Post trashed" before redirecting.

Trac ticket:

#4 @James Roberts
2 months ago

  • Keywords needs-testing added

@James Roberts commented on PR #4253:

2 months ago

E2E test locally gives the following results:

Test Suites: 6 passed, 6 total
Tests:       15 passed, 15 total
Snapshots:   0 total
Time:        117.714 s, estimated 224 s

Would it be possible to re-run it?

Note: See TracTickets for help on using tickets.