WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #51393, comment 2


Ignore:
Timestamp:
09/25/2020 12:55:37 AM (6 years ago)
Author:
SergeyBiryukov

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #51393, comment 2

    initial v1  
    33Regardless, the correct schema type is an `object`. See https://developer.wordpress.org/rest-api/extending-the-rest-api/schema/#primitive-types for reference.
    44
    5 > The tests should probably be updated to check if $data['media_details']['sizes'] is not empty before proceeding
     5> The tests should probably be updated to check if `$data['media_details']['sizes']` is not empty before proceeding
    66
    77I think this is the correct fix. Changing the data values in the controller would be a BC break.