Opened 6 years ago
Closed 6 years ago
#51401 closed enhancement (fixed)
Docs: Fix bracket issue in autosave JS DocBlock
| Reported by: | dilipbheda | Owned by: | SergeyBiryukov |
|---|---|---|---|
| Priority: | normal | Milestone: | 5.6 |
| Component: | Autosave | Version: | 5.6 |
| Severity: | normal | Keywords: | has-patch commit |
| Cc: | Focuses: | javascript, docs |
Description
Fix inline documentation.
Attachments (2)
Change History (8)
#4
@
6 years ago
- Keywords commit added
- Type defect (bug) → enhancement
51401.1.patch thanks for update.
Patch looks good. Marking for commit.
#5
@
6 years ago
- Milestone Awaiting Review → 5.6
- Owner set to
- Status new → reviewing
Thanks for the patch!
I haven't found any other instances in core where we document object properties like this, but the closest match appears to be the "Record Type" from Google JavaScript Style Guide:
{{myNum: number, myObject}}
So it looks like double brackets are OK, let's just correct the second bracket placement.
Note:
See TracTickets
for help on using tickets.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
Hi there!
The 51401.patch patch needs update because you have added an extra }.