![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
#51408 closed defect (bug) (fixed)
For WP 5.6: remove a core theme, to bundle only three themes
| Reported by: | joyously | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | 5.6 |
| Component: | Bundled Theme | Version: | |
| Severity: | normal | Keywords: | |
| Cc: | Focuses: |
Description
For 5.6, the Twenty Twenty One theme will be added.
Will one of the current bundled themes be removed?
At one point, WP contained 4 themes, and the zip file was larger than it had been. I had trouble with installation due to timeouts, and I saw a few other reports of this in the forums.
But which theme to remove?
Do you choose the oldest or the largest or the one with the most bug reports?
Removing the oldest results in 3 very similar looking themes.
Removing the largest addresses the bundle size problem directly but leaves a gap in the sequence.
Removing the buggiest improves the WP package (default theme is often used as a way to test user problems).
Change History (7)
#1
in reply to: ↑ description
@
6 years ago
- Milestone Awaiting Review
- Resolution → invalid
- Status new → closed
#2
@
6 years ago
@SergeyBiryukov was able to gather some more details around this as well (of course I saw right after I submitted my comment above 😃):
- 3.0, 3.1: Twenty Ten
- 3.2, 3.3, 3.4: Twenty Ten, Eleven
- 3.5: Twenty Ten, Eleven, Twelve
- 3.6, 3.7: Twenty Twelve, Thirteen
- 3.8, 3.9, 4.0: Twenty Twelve, Thirteen, Fourteen
- 4.1, 4.2, 4.3: Twenty Thirteen, Fourteen, Fifteen
- 4.4, 4.5, 4.6: Twenty Fourteen, Fifteen, Sixteen
- 4.7, 4.8, 4.9: Twenty Fifteen, Sixteen, Seventeen
- 5.0, 5.1, 5.2: Twenty Sixteen, Seventeen, Nineteen
- 5.3: Twenty Sixteen, Seventeen, Nineteen, Twenty
- 5.4, 5.5: Twenty Seventeen, Nineteen, Twenty
I am still recalling that I saw the policy was 2 default themes, but seeing that a majority of releases contained 3, I may have been confusing that with a discussion to change the number of bundled themes to 2.
#4
@
6 years ago
- Resolution wontfix
- Status closed → reopened
I don't understand why this is closed. The purpose is to track the removal of one of the themes. When we had 4 at once, the zip file size caused issues for those of us with slow connections, so I'm trying to prevent that slipping by unnoticed.
Also, this is not something that can be addressed here as it requires a commit to the private WP.org repository so I am going to close this out.
Aren't the bundled themes are part of the trunk? They live in two places once released, and still bundled.
There has to be something, maybe part of the build, to list the ones that get into the zip file.
#5
@
6 years ago
- Resolution → fixed
- Status reopened → closed
There has to be something, maybe part of the build, to list the ones that get into the zip file.
Yup, it's in the WordPress.org build system, not core. The scripts that create the release zips for WordPress have a list of which themes to exclude from which versions (Beta/RC/Stable releases only)
In r16490-dotorg I've made the required change, way ahead of time, because there was no reason not to.
-
release.php
93 93 $themes = array( 94 94 'twentyten' => '3.5-alpha', 95 95 'twentyeleven' => '3.6-alpha', 96 96 'twentytwelve' => '4.1-alpha', 97 97 'twentythirteen' => '4.4-alpha', 98 98 'twentyfourteen' => '4.7-alpha', 99 99 'twentyfifteen' => '5.0-alpha', 100 100 'twentysixteen' => '5.3-alpha', 101 'twentyseventeen' => '5.6-alpha', 101 102 ); 102 103 103 104 foreach ( $themes as $theme => $version_removed )
I've assumed Twenty Seventeen was probably the one to be dropped, if that's not the case, it'll have to be updated when that decision is made.
The nightlies still contain every default theme (Twenty Ten to Twenty Twenty currently), so this change won't be seen until 5.6-Beta1 is released.
Replying to joyously:
When a new default bundled theme is released, WordPress Core is updated to only include the 2 newest when creating the release packages. This is documented somewhere, but I am unable to locate where at this time. I'm going to work on locating where I have seen this documented and I'll add a note on the Releasing Major Versions page in the Handbook so it's not forgotten on release day (I believe that 3 themes were mistakenly left initially for 5.0).
All of the Twenty X default themes continue to be officially supported. If any of them contain bugs, let's try to ensure those bugs are documented with Trac tickets so that they can be fixed. Choosing to arbitrarily exclude them in favor of other "less buggy" default themes does not help users that prefer using those themes (Twenty X themes are active on almost 20% of all WordPress installs).
Also, this is not something that can be addressed here as it requires a commit to the private WP.org repository so I am going to close this out.