WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #51423, comment 96


Ignore:
Timestamp:
04/19/2021 04:08:02 PM (3 years ago)
Author:
hellofromTonya
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #51423, comment 96

    initial v1  
    1 @SergeyBiryukov What do I think?
     1@SergeyBiryukov Great job running the performance benchmarks on the 2 approaches!
     2
     3
     4>What do I think?
    25
    36Type casting code: it's more concise with less lines of code, but IMO less understandable for what happens and why with different values or lack of value.
    … …  
    58Why? When I read it, my first thought is: why is it type casting and doing the processing when there are no emails to be processed.
    69
    7 I'd vote for the empty/is_array version for quick understanding and eliminating unnecessary processing.
     10I'd vote for the empty/is_array version for quick understanding, eliminating unnecessary processing, and clear showing the processing paths for different values (which helps with building happy and unhappy path testing scenarios).