WordPress.org

Make WordPress Core

Opened 9 months ago

Closed 8 months ago

#51426 closed defect (bug) (fixed)

@param boolean To @param bool

Reported by: ravipatel Owned by: johnbillion
Milestone: 5.6 Priority: normal
Severity: normal Version:
Component: General Keywords: has-patch
Focuses: docs Cc:

Description

@param boolean to bool

Per core's PHP documentation standards:
For boolean and integer types, use bool and int, respectively.

Attachments (4)

51426.patch (2.8 KB) - added by ravipatel 9 months ago.
Per core's PHP documentation standards: For boolean and integer types, use bool and int, respectively.
51426-php-code-standards.patch (14.0 KB) - added by ravipatel 9 months ago.
Per core's PHP documentation standards: use bool and int
51426-php-code-standards-1.patch (4.0 KB) - added by ravipatel 9 months ago.
include this patch with 2 replaced @return integer to int
51426.diff (33.0 KB) - added by justinahinon 9 months ago.

Download all attachments as: .zip

Change History (10)

@ravipatel
9 months ago

Per core's PHP documentation standards: For boolean and integer types, use bool and int, respectively.

This ticket was mentioned in Slack in #core by ravi. View the logs.


9 months ago

@ravipatel
9 months ago

Per core's PHP documentation standards: use bool and int

@ravipatel
9 months ago

include this patch with 2 replaced @return integer to int

#3 @justinahinon
9 months ago

It may be good to explore other parts in Core when this change can be made also.

@justinahinon
9 months ago

#4 @justinahinon
9 months ago

I've merged the changes in the three patches proposed by @ravipatel as well as refreshed against trunk.

#5 @johnbillion
9 months ago

  • Focuses coding-standards removed
  • Milestone changed from Awaiting Review to 5.6
  • Owner set to johnbillion
  • Status changed from new to accepted
  • Version trunk deleted

Thanks for the patches @ravipatel @justinahinon.

Note that some of these files are third party libraries that we usually don't change (eg. Requests and SimplePie), but the changes in WordPress core files look good.

Last edited 9 months ago by johnbillion (previous) (diff)

#6 @johnbillion
8 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 49120:

Docs: Standardise the type name for booleans and integers.

This brings these docs inline with the documentation standards.

Props ravipatel, justinahinon

Fixes #51426

Note: See TracTickets for help on using tickets.