Docs: Undocumented @global instances

[ravipatel]

@global wpdb not define on line no 230.

display_setup_form() on define but not call outside of the function.

[ravipatel]

codeing standard undefine varible.

[davidbaumwald]

@ravipatel Can you refresh these patches against the src? The patch does not include the file path and is more difficult to apply. For instance, install.php should be src/wp-admin/install.php.

Here's a Handbook page about creating the patch from src/ ​https://make.wordpress.org/core/handbook/tutorials/trac/submitting-a-patch/

[ravipatel]

Added with full path for undefined varibale

[ravipatel]

Added file patch another file - undefined variable

[ravipatel]

Combile all chnages + $post_id missing to define on comment file.

[ravipatel]

$comment & $action not defined edit-form-comment.php

[davidbaumwald]

@ravipatel Looking at these patches more in depth, it looks like most of these added global vars are not necessary, as they are already defined earlier in execution. For example, this patch is not necessary. edit-form-comment.php is an included template, and both $action and $comment are defined in the parent file src/wp-admin/comment.php. Same goes for the $typenow and $wpdb in src/wp-admin/edit.php.

I'm adding the close keyword because I think this ticket is not needed. I'll leave it open for a couple of days to see if anyone think s this does deserve to be a standalone ticket. Please ensure that these variables are indeed undefined at runtime, if they aren't I suggest adding to this ticket instead.

[ravipatel]

@davidbaumwald
OK, but applied some changes which is right for a declaration for variables as per PHP code doc format.

[hellofromTonya]

The changes in the install.php file are from Version 4.2 rather than 5.6 (trunk), ie per Ticket #30799. Changing the Version to 4.2.