Opened 4 months ago
Last modified 2 months ago
#51439 new defect (bug)
Docs: Undocumented @global instances
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | Awaiting Review | Priority: | low |
Severity: | normal | Version: | 4.2 |
Component: | General | Keywords: | has-patch needs-refresh close |
Focuses: | docs, coding-standards | Cc: |
Description
@global wpdb not define on line no 230.
display_setup_form() on define but not call outside of the function.
Attachments (5)
Change History (11)
#2
@
4 months ago
- Keywords needs-refresh added
- Priority changed from normal to low
@ravipatel Can you refresh these patches against the src
? The patch does not include the file path and is more difficult to apply. For instance, install.php
should be src/wp-admin/install.php
.
Here's a Handbook page about creating the patch from src/ https://make.wordpress.org/core/handbook/tutorials/trac/submitting-a-patch/
This ticket was mentioned in Slack in #core by ravi. View the logs.
4 months ago
#4
@
4 months ago
- Focuses docs added
- Keywords close added
- Summary changed from Undefined Varible - Codeing Standard to Docs: Undocumented @global instances
@ravipatel Looking at these patches more in depth, it looks like most of these added global vars are not necessary, as they are already defined earlier in execution. For example, this patch is not necessary. edit-form-comment.php
is an included template, and both $action
and $comment
are defined in the parent file src/wp-admin/comment.php
. Same goes for the $typenow
and $wpdb
in src/wp-admin/edit.php
.
I'm adding the close
keyword because I think this ticket is not needed. I'll leave it open for a couple of days to see if anyone think s this does deserve to be a standalone ticket. Please ensure that these variables are indeed undefined at runtime, if they aren't I suggest adding to this ticket instead.
codeing standard undefine varible.