WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#51473 closed defect (bug) (fixed)

<ul> tag missing in tests/qunit/index.html

Reported by: ravipatel Owned by: SergeyBiryukov
Priority: normal Milestone: 5.6
Component: Build/Test Tools Version: 4.6
Severity: normal Keywords: has-patch
Cc: Focuses: coding-standards

Description


Attachments (1)

51473-index.html.patch​ (661 bytes ) - added by ravipatel 6 years ago.
Ui tag missing

Download all attachments as: .zip

Change History (8)

@ravipatel
6 years ago

Ui tag missing

This ticket was mentioned in ​Slack in #core by ravi. ​View the logs.
6 years ago

#2 @JeffPaul
6 years ago

Looks like a stray </ul> on line 2305 and </li> on line 2304 can be removed perhaps? I haven't looked at the larger file but a quick scan of the changes seems like those may be errant?

#3 @ravipatel
6 years ago

@JeffPaul yes because of 2305 </ul> is inner ul tag which start from 2293.
Please review whole file & compare. I have shared right patch.

See exiting code without patch : https://prnt.sc/uvkb0m

#4 @SergeyBiryukov
6 years ago

  • Focuses ui removed
  • Milestone Awaiting Review → 5.6
  • Summary Html Tag Missing → <ul> tag missing in tests/qunit/index.html

#5 @SergeyBiryukov
6 years ago

  • Owner set to SergeyBiryukov
  • Resolution → fixed
  • Status new → closed

In 49107:

Build/Test Tools: Add missing <ul> tag in tests/qunit/index.html.

Props ravipatel, JeffPaul.
Fixes #51473.

#6 @SergeyBiryukov
6 years ago

For reference, the section was introduced in [37714].

#7 @SergeyBiryukov
6 years ago

  • Version trunk → 4.6
Note: See TracTickets for help on using tickets.