2 elements with non unique id #_wpnonce in post.php

[vandestouwe]

In the file post.php when a page is edited 2 element are found to have the same id.

1. on line 2306: <?php wp_nonce_field( 'toggle-custom-fields'); ?>
2. on line 2424: wp_nonce_field( $nonce_action);

Both forms are active causing a warning on the console of the webbrowser

In the included php file both lines have been given a unique id

[vandestouwe]

The corrected post.php

[Mista-Flo]

Hi @vandestouwe, welcome on trac!

Could you please a bit more information about the issue. Is that happening with the new block editor? Do you have some special plugins enabled like Classic Editor?

Could you also check that link in order to create a valid patch in trac.

​https://make.wordpress.org/core/handbook/tutorials/working-with-patches/
​https://make.wordpress.org/core/handbook/best-practices/writing-patches/

If you're familiar with code and git, you can use the wordpress-develop Github repository to easily contribute to WordPress: ​https://make.wordpress.org/core/handbook/contribute/git/

[vandestouwe]

The patch file to correct the issue

[vandestouwe]

I'm using the bock editor. The warning comes when i want to edit the page. No special plugins are installed. This is a normal page with a form as you can see in link: ​https://www.vandestouwe.com/subscribe when I want to edit this page you can find the warning message on the console of the web browser.

[noisysocks]

I was able to confirm the bug locally.

@vandestouwe: Could you please refresh the patch? It no longer applies cleanly.

[Mista-Flo]

Patch refreshed

[Mista-Flo]

Hi @noisysocks I have refreshed the patch, applied coding standards and removed an unused local variable as well.

[noisysocks]

Thanks @Mista-Flo! LGTM, though we'll still want the space before the />.

[ocean90]

This is related to #23165, especially the comment ticket:23165:15. For now I'd suggest to only change toggle-custom-fields. Please keep in mind that you also have to set the $query_arg parameter for the check_admin_referer() call.

[Mista-Flo]

3rd patch to fix check admin referer

[Mista-Flo]

Replying to ocean90:

This is related to #23165, especially the comment ticket:23165:15. For now I'd suggest to only change toggle-custom-fields. Please keep in mind that you also have to set the $query_arg parameter for the check_admin_referer() call.

Hi @ocean90, good catch, thanks for the help! I fixed the issue in last patch

[ocean90]

In 50255:

Block Editor: Use a unique name for the nonce of the custom fields toggle form.

Avoids a browser warning for having two elements with a non-unique id #_wpnonce on the post edit screen.

See #23165.
Fixes #51483.
Props vandestouwe, Mista-Flo.