#51487 closed enhancement (fixed)
Update 3rd-party Video Unit Tests to use more permanent videos
Reported by: | garrett-eclipse | Owned by: | garrett-eclipse |
---|---|---|---|
Milestone: | 5.6 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Media | Keywords: | has-patch has-unit-tests commit |
Focuses: | Cc: |
Description
This is a follow-up ticket from a discussion on slack, ticket in meta and associated core ticket #46986. To answer, what videos to use in unit tests for vimeo and youtube.
I'll quote the meta response from @dd32 as I feel it the most appropriate path forward;
Instead of using WordPress test accounts, could we instead fall back onto using a video uploaded by the embed company instead?
For example, for Vimeo, anything from
Vimeo Staff
https://vimeo.com/staff or the test video from https://player.vimeo.com/embed should be safe to use going forward. edit: The player embed page actually has a bunch of test videos with various states, such as not-embeddable, hosted by official vimeo test accounts, seems perfect for this use-case.
Having official WordPress accounts for every embed platform is not going to be viable from a management perspective IMHO, and having accounts everywhere with only a single W logo video doesn't lead to a super great experience when it ends up in search results.
Where WordPress does have a use for the service (Such as Youtube) using one of our uploads such as a release video does make sense though.
This ticket is to update those urls to use the youtube suggested video and the one from the Vimeo embed tutorial.
Youtube - https://www.youtube.com/watch?v=72xdCU__XCk
Vimeo - https://vimeo.com/76979871
Attachments (1)
Change History (9)
#1
@
4 years ago
Note: While creating the patch I found some instances in Gutenberg so once this gets some review we can look to also bring consistency to those tests too.
#2
@
4 years ago
- Keywords needs-testing removed
Hey Garrett, nice one!
I have run the unit tests with the patch applied and it works, no regression.
This ticket was mentioned in Slack in #core-media by hellofromtonya. View the logs.
4 years ago
#4
@
4 years ago
- Keywords commit added
- Milestone changed from Awaiting Review to 5.6
Awesome, let's get a committers review and see if we can land this in 5.6.
This ticket was mentioned in Slack in #docs by garrett-eclipse. View the logs.
4 years ago
#8
@
4 years ago
Thanks @SergeyBiryukov I've added a note to the Automated Testing document here;
https://make.wordpress.org/core/handbook/testing/automated-testing/
Initial patch to bring consistency to the vimeo/youtube urls used for tests.