Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#51488 closed enhancement (invalid)

Docs: Fix single quote issue in postbox and media JS DocBlock

Reported by: dilipbheda's profile dilipbheda Owned by:
Milestone: Priority: normal
Severity: normal Version: 5.6
Component: Administration Keywords: has-patch close
Focuses: javascript, docs Cc:

Description

Fix inline documentation.

Attachments (1)

51488.patch (1.4 KB) - added by dilipbheda 3 years ago.

Download all attachments as: .zip

Change History (3)

@dilipbheda
3 years ago

#1 @sabernhardt
3 years ago

  • Keywords close added

The apostrophe was in the correct spot for referring to multiple inputs (and their attributes/values). Am I missing sonething?

Version 1, edited 3 years ago by sabernhardt (previous) (next) (diff)

#2 @SergeyBiryukov
3 years ago

  • Component changed from General to Administration
  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed

Thanks for the patch! The existing apostrophes are indeed correct, see Apostrophe Rules by Grammarly:

For most singular nouns, add apostrophe+s:
Example: The dog’s leash The writer’s desk The planet’s atmosphere

For most plural nouns, add only an apostrophe:
Example: The dogs’ leashes (multiple dogs) The writers’ desks (multiple writers) The planets’ atmospheres (multiple planets)

Note: See TracTickets for help on using tickets.