Make WordPress Core

Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#51489 closed task (blessed) (fixed)

Application Passwords: Add some additional explanation for Multisite instances

Reported by: georgestephanis's profile georgestephanis Owned by: sarahricker's profile sarahricker
Milestone: 5.6 Priority: normal
Severity: normal Version: 5.6
Component: Login and Registration Keywords: has-patch needs-copy-review needs-refresh
Focuses: multisite, rest-api Cc:

Description

To properly set expectations for users, when the WordPress install is a Multisite install, and the current user has roles on multiple blogs, display an extra blurb on the authorization flow and application passwords section of the user profile screen saying something to the effect of:

Application Passwords will also grant the application access the other {$num_blogs} blogs that you have permissions on.

(along with possibly listing them if it's a short list, or a link to a page in the user dashboard or multisite dashboard listing the user's blogs)

As we'd be displaying it in two places, I'm unsure if it would be worth abstracting to a function or just inlining it both places.

For future v2 buildout, as we're looking at adding additional ability to scope application passwords access, being able to limit the sites they are used on may be worth including in that addition.

Props @spacedmonkey for asking multisite related questions that made me think of this.

Change History (23)

This ticket was mentioned in Slack in #core-passwords by georgestephanis. View the logs.


4 years ago

#2 @johnjamesjacoby
4 years ago

I support additional clarity here. Suggest to start by linking to the “My Sites” admin page, and iterate if it is determined to be insufficient.

This ticket was mentioned in Slack in #core by hellofromtonya. View the logs.


3 years ago

#4 @hellofromTonya
3 years ago

  • Type changed from enhancement to task (blessed)

As discussed in scrub, converting this to task.

#5 @sarahricker
3 years ago

Per today's bug scrub, this ticket (now a task) will stay in 5.6 (and after Beta 1 if necessary) as it aims to refine a new feature that has already been merged into trunk.

@georgestephanis and @spacedmonkey - Can you add the exact copy for each location it will be added to this ticket to ensure it is good to go?

Thanks!

This ticket was mentioned in PR #635 on WordPress/wordpress-develop by georgestephanis.


3 years ago
#6

  • Keywords has-patch added

Add explanation text in multisite environments when the user has multiple blogs clarifying that application passwords will grant access to all their sites.

Trac ticket: https://core.trac.wordpress.org/ticket/51489

#7 @georgestephanis
3 years ago

@sarahricker Created a github pr for review and discussion. Honestly I'm horrid on verbiage and phrasing, but the context there should be enough for someone better with words for users to make it intelligible. :\

This ticket was mentioned in Slack in #core by hellofromtonya. View the logs.


3 years ago

#9 @sarahricker
3 years ago

  • Keywords needs-copy-review added

Thanks @georgestephanis, that is perfect! Will take a look. Will try to get it in Beta 1, but if not - Beta 2!

#10 @TimothyBlynJacobs
3 years ago

This will grant access to all 10 blogs in this installation that you have permissions on. and Application passwords grant access to all 10 blogs in this installation that you have permissions on.

#11 @sarahricker
3 years ago

  • Owner set to sarahricker
  • Status changed from new to accepted

TimothyBJacobs commented on PR #635:


3 years ago
#12

@georgestephanis looks like there are linting failures.

#13 @SergeyBiryukov
3 years ago

  • Keywords needs-refresh added

A couple of notes:

  • The strings should use _n() instead of __() here, many languages have more than one plural form.
  • sizeof() should be replaced with count(), see [49193].

georgestephanis commented on PR #635:


3 years ago
#14

Yeah, just fixed.

TimothyBJacobs commented on PR #635:


3 years ago
#15

@SergeyBiryukov's also left comments on the ticket.

#16 @georgestephanis
3 years ago

Updated addressing _n and count feedback.

This ticket was mentioned in Slack in #core-passwords by georgestephanis. View the logs.


3 years ago

#18 @TimothyBlynJacobs
3 years ago

  • Component changed from Networks and Sites to Login and Registration
  • Focuses rest-api added

#19 @TimothyBlynJacobs
3 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 49270:

App Passwords: Explain that apps can access to all sites in a network.

Props georgestephanis, spacedmonkey, johnjamesjacoby, SergeyBiryukov, marybaum.
Fixes #51489.

#20 follow-up: @johnjamesjacoby
3 years ago

Is there a compelling reason why the HTML for this feature does not follow the pattern set by every other user profile feature on this page?

This feature would feel much more complete if it did not look as unique and unfamiliar.

Any objections to reopening & continuing to iterate on this during beta?

#21 @georgestephanis
3 years ago

@johnjamesjacoby Which aspect of the html do you mean?

And I'm fine with reopening this ticket if it's about the new multisite line specifically, but if it's a grander rearchitecting, may be better to do a new ticket.

#22 @SergeyBiryukov
3 years ago

In 49282:

Coding Standards: Update some alignment in wp-admin/authorize-application.php for consistency.

Save blogs count to a variable for reusing.

Follow-up to [49270].

See #51489.

#23 in reply to: ↑ 20 @SergeyBiryukov
3 years ago

Replying to johnjamesjacoby:

Is there a compelling reason why the HTML for this feature does not follow the pattern set by every other user profile feature on this page?

This feature would feel much more complete if it did not look as unique and unfamiliar.

Follow-up: #51899

Note: See TracTickets for help on using tickets.