WordPress.org

Make WordPress Core

Opened 5 months ago

Last modified 5 months ago

#51519 new defect (bug)

Remove use of jQuery ready()

Reported by: wpnomad Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: General Keywords: needs-patch
Focuses: javascript Cc:

Description

ready() has been [deprecated](​https://api.jquery.com/ready/), but we still use it in some places:

  • wp-content/themes/twentytwenty/assets/js/customize.js

(and maybe more).

Can this be reviewed? A report to change the same in WooCommerce core is here: ​https://github.com/woocommerce/woocommerce/issues/27945

Change History (2)

#1 @sabernhardt
5 months ago

  • Focuses javascript added
  • Keywords needs-patch added

Yes, several admin scripts and most bundled themes use .ready() at least once.

Related: #37110 and #50564

#2 @malthert
5 months ago

I reported this originally for WP (& also the WooCommerce issue is from me) - I think in fact we should not only change the .ready() event, but also include info about this change somewhere prominently, so all plugin authors are aware that they should change it too.

The process for this has already been started for all plugins sold on WooCommerce, so this will be finished before WP5.6 is released for those at least.

Note: See TracTickets for help on using tickets.