PHP 8.0: Update SimplePie to version 1.5.6

[jrf]

The SimplePie libary contained a number of incompatibilites with PHP 8.0.

In as far as these have been discovered so far, these are fixed in the newest release 1.5.6, which has just come out.

With that in mind, the SimplePie library should be updated.

Refs:

• ​https://github.com/simplepie/simplepie/releases/tag/1.5.6
• ​https://github.com/simplepie/simplepie/compare/1.5.5...master

Previous: #36669

[ravipatel]

@desrosj
Need to improvement in code still. required changes on see tag. #51441

​https://github.com/simplepie/simplepie/blob/1.5.6/library/SimplePie.php

Please review this changes which all ready approved but a third party files on not applied.

line no 2127 / 2527

* @see get_link to * @see get_link()

line no : 2991

* @see get_item_quantity to * @see get_item_quantity()

line no 2128:
* @see subscribe_url to * @see subscribe_url()

https://core.trac.wordpress.org/attachment/ticket/51441/51441-multiple-files.patch

[desrosj]

@ravipatel Because this is an external library that is copied verbatim into WordPress, the changes you are noting would need to be made upstream in the SimplePie repository. If you'd like to see these fixed, I recommend opening an issue or a pull request there.

51521.diff​ applies the latest 1.5.6 update in trunk. An extra set of eyes to verify would be appreciated

[ayeshrajans]

(Extra eyes) I can also confirm that the patch applies cleanly, and the content are verbatim 1.5.6 from upstream, with changes in the class-simplepie.php file containing the class with WP's own autoloader, plus the additional phpcs:ignore PHPCompatibility.FunctionUse.ArgumentFunctionsReportCurrentValue.NeedsInspection line.

[desrosj]

Thanks @ayeshrajans!

[desrosj]

In 49176:

External Libraries: Update the SimplePie library to version 1.5.6.

This version fixes a handful of PHP 8 compatibility issues.

A full list of changes included in this update can be found on GitHub: ​https://github.com/simplepie/simplepie/compare/1.5.5...1.5.6.

Props jrf, ayeshrajans.
Fixes #51521.