Make WordPress Core

Opened 5 years ago

Closed 8 months ago

Last modified 8 months ago

#51522 closed defect (bug) (worksforme)

Customizing : Site Icon CSS Change

Reported by: ravipatel's profile ravipatel Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Customize Keywords: has-patch 2nd-opinion
Focuses: css Cc:

Description

When image not exits on provided path display css issue.
Please review bellow screenshots.

Issue :

https://prnt.sc/uzb75e

Solution :

https://prnt.sc/uzb622

Attachments (4)

51522-site-icon.css.patch (382 bytes) - added by ravipatel 5 years ago.
css changes for a site icon
site-icon-missing-image.png (39.0 KB) - added by sabernhardt 8 months ago.
alternative text showing for the app icon and browser icon, in light and dark previews
site-icon-missing-image-general-settings-light.png (27.9 KB) - added by sabernhardt 8 months ago.
site icon in General Settings, with light mode
site-icon-missing-image-general-settings-dark.png (26.8 KB) - added by sabernhardt 8 months ago.
site icon in General Settings, with dark mode

Download all attachments as: .zip

Change History (9)

@ravipatel
5 years ago

css changes for a site icon

#1 @dlh
5 years ago

  • Component changed from Administration to Customize
  • Focuses ui removed
  • Keywords reporter-feedback added
  • Version trunk deleted

Hi @ravipatel,

I'm having difficulty understanding the issue from the screenshots. Could you provide steps to replicate the issue?

#2 @ravipatel
5 years ago

1) Add favicon icon - I am using png image

2) Remove from upload directory or rename image name temp for show wrong path

3) After image path not found you can see this ui issue.

https://prnt.sc/uzb75e

#3 @sabernhardt
5 years ago

  • Keywords needs-refresh 2nd-opinion added; reporter-feedback removed

"Remove from upload directory or rename image" is the key step to reproduce the missing image error. When the site icon image is deleted in the media library, the site icon setting is removed and the Customizer no longer tries to show a preview.

To adjust the alt text styles, setting display: inline-block and changing the color works here. Including the padding is not a good option, though, because it would change the app icon preview when the image exists at the expected URL.

Last edited 5 years ago by sabernhardt (previous) (diff)

@sabernhardt
8 months ago

alternative text showing for the app icon and browser icon, in light and dark previews

#4 @sabernhardt
8 months ago

  • Keywords needs-refresh removed
  • Milestone Awaiting Review deleted
  • Resolution set to worksforme
  • Status changed from new to closed

I tried this again, and the styles have changed.

  • The App icon preview is inside grid display, with dark text against a light background, so the image does not need display: inline-block or a text color anymore for its alternative text.
  • The Browser icon preview does not make the alt text very readable in either light or dark mode. The image theoretically could have a text color like var(--site-icon-address-bar-text), but that still would be difficult to read when "Browser" overlaps the Site Title.

I think being able to read the text in the App icon image effectively indicates that you need to 'Remove' or 'Change image' when the image does not exist at the same URL.

@sabernhardt
8 months ago

site icon in General Settings, with light mode

@sabernhardt
8 months ago

site icon in General Settings, with dark mode

#5 @sabernhardt
8 months ago

The General Settings page has similar results when showing alt text in the site icon previews.

Note: See TracTickets for help on using tickets.